Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '--logging-format' flag to kube-proxy #117800

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Add '--logging-format' flag to kube-proxy #117800

merged 2 commits into from
Jul 13, 2023

Conversation

cyclinder
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add '--logging-format' flag to kube-proxy

Which issue(s) this PR fixes:

Fixes #105165

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-proxy: add '--logging-format' flag to support structured logging

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 5, 2023
@cyclinder
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. area/code-generation area/kube-proxy kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from bowei and caesarxuchao May 5, 2023 09:43
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 5, 2023
danwinship
danwinship suggested changes May 8, 2023
View reviewed changes
cmd/kube-proxy/app/server.go Outdated Show resolved Hide resolved
cmd/kube-proxy/app/server.go Outdated Show resolved Hide resolved
cmd/kube-proxy/app/server_test.go Outdated Show resolved Hide resolved
pkg/proxy/apis/config/types.go Outdated Show resolved Hide resolved
pkg/proxy/apis/config/scheme/testdata/KubeProxyConfiguration/after/v1alpha1.yaml Outdated Show resolved Hide resolved
pkg/proxy/apis/config/validation/validation_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested review from liggitt and pohly May 9, 2023 06:15
@cyclinder cyclinder force-pushed the loggin_format branch 2 times, most recently from d410cf7 to 0da48f5 Compare May 9, 2023 08:42
@cyclinder cyclinder force-pushed the loggin_format branch 2 times, most recently from 0b68872 to f78aa80 Compare May 9, 2023 14:20
@cici37
Copy link
Contributor

cici37 commented May 9, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 875d9cd83310a7f9a4dce98da4f24268c61fa0f6

@liggitt
Copy link
Member

liggitt commented Jul 12, 2023

unmarshal behavior needs a unit test, then lgtm

@liggitt liggitt self-assigned this Jul 12, 2023
@cyclinder
Copy link
Contributor Author

Also, Does the duration commit need to be a separate PR?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from liggitt and pohly July 13, 2023 06:33
@cyclinder
Copy link
Contributor Author

/test pull-kubernetes-unit

@liggitt
Copy link
Member

liggitt commented Jul 13, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d42e974c967bdc1f8817b772a4862c916803bbcf

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, liggitt, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit d37c62d into kubernetes:master Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 13, 2023
This was referenced Jul 14, 2023
Closed
Closed
aojea
aojea reviewed Aug 9, 2023
View reviewed changes
pkg/proxy/apis/config/scheme/testdata/KubeProxyConfiguration/after/v1alpha1.yaml
options:
json:
infoBufferSize: "0"
verbosity: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is defaulting the verbosity to 0 and overriding the flag value, that was the common way to configure the verbosity of kube-proxy, you can see per example that our CI no longer leverages the flag verbosity https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-kind-e2e-parallel/1689121775398424576/artifacts/kind-control-plane/pods/kube-system_kube-proxy-qz9f6_8e49f584-22b5-4008-9442-b2fae2a3ea75/kube-proxy/0.log

@aojea aojea mentioned this pull request Aug 9, 2023
Closed
@pohly pohly mentioned this pull request Aug 9, 2023
Closed
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
@caohe caohe mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@danwinship danwinship danwinship requested changes

@bowei bowei Awaiting requested review from bowei

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@liggitt liggitt Awaiting requested review from liggitt

@pohly pohly Awaiting requested review from pohly

Assignees

@pohly pohly

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/kube-proxy area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
API Reviews
Status: API review completed, 1.28
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Introduce JSON logging format for kube-proxy