Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update etcd dependencies to v3.5.9 #117645

Merged
merged 2 commits into from
May 15, 2023
Merged

dependencies: update etcd dependencies to v3.5.9 #117645

merged 2 commits into from
May 15, 2023

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 27, 2023 •
edited
Loading

/kind cleanup

NONE

We have bumped the image references of etcd to v3.5.9 via:
#117332

so keeping the api dependency to the same version in this PR.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 27, 2023
@k8s-ci-robot k8s-ci-robot requested review from cheftako, deads2k and a team April 27, 2023 12:43
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2023
@humblec humblec changed the title dependencies: update etcd dependencies to v3.5.8 [wip] dependencies: update etcd dependencies to v3.5.8 Apr 27, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 27, 2023
@humblec humblec force-pushed the etcd-2 branch 2 times, most recently from ac6a17f to 579f958 Compare May 11, 2023 16:29
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@humblec humblec changed the title [wip] dependencies: update etcd dependencies to v3.5.8 dependencies: update etcd dependencies to v3.5.8 May 11, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@kkkkun kkkkun mentioned this pull request May 12, 2023
Closed
4 tasks
@humblec humblec changed the title dependencies: update etcd dependencies to v3.5.8 dependencies: update etcd dependencies to v3.5.9 May 13, 2023
@humblec
Copy link
Contributor Author

humblec commented May 13, 2023

/assign @serathius
cc @kkkkun

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2023
humblec added 2 commits May 14, 2023 12:24
@humblec
etcd depdencies are updated to v3.5.9
ae74923 
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@humblec
update vendor dependencies for the change
dcefc42 
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2023
@kkkkun
Copy link
Member

kkkkun commented May 14, 2023

LGTM，Thanks @humblec

@humblec
Copy link
Contributor Author

humblec commented May 15, 2023

@jpbetz can you please take a look at this change?

@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1d5606c378eeb7638884e5711ec9408453c446b

@humblec
Copy link
Contributor Author

humblec commented May 15, 2023

cc @dims for approval :)

@dims
Copy link
Member

dims commented May 15, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, humblec, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3a65b98 into kubernetes:master May 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 15, 2023
@pacoxu pacoxu mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@dims dims

@jpbetz jpbetz

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
7 participants
@humblec @kkkkun @k8s-ci-robot @jpbetz @k8s-triage-robot @serathius @dims