Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing WindowsHostProcessContainers feature-gate #117570

Merged
merged 1 commit into from
May 1, 2023
Merged

Removing WindowsHostProcessContainers feature-gate #117570

merged 1 commit into from
May 1, 2023

Conversation

marosset
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

WindowsHostProcessContainers went stable in v1.26 and it is now time to remove the feature gate

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removing WindowsHostProcessContainers feature-gate

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/issues/1981

/sig windows

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 24, 2023
@marosset
Copy link
Contributor Author

part of kubernetes/enhancements#1981

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 24, 2023
@marosset
Copy link
Contributor Author

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 24, 2023
@k8s-ci-robot k8s-ci-robot requested review from deads2k and dims April 24, 2023 23:49
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@bart0sh
Copy link
Contributor

bart0sh commented Apr 25, 2023

/triage accepted
/priority important-longterm
/cc

@k8s-ci-robot k8s-ci-robot requested a review from bart0sh April 25, 2023 10:39
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2023
@marosset marosset force-pushed the remove-hostprocess-containers-featuregate branch from d46e28c to a42c4e0 Compare April 25, 2023 17:59
@marosset marosset mentioned this pull request Apr 25, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 100a52002209585ad7133bc3b6ce1e8dcc611572

@jsturtevant
Copy link
Contributor

/lgtm

@marosset
Copy link
Contributor Author

marosset commented May 1, 2023

/assign @dims @liggitt

liggitt
liggitt reviewed May 1, 2023
View reviewed changes
pkg/kubelet/metrics/metrics.go Outdated
@@ -613,7 +613,7 @@ var (
&metrics.CounterOpts{
Subsystem: KubeletSubsystem,
Name: StartedHostProcessContainersTotalKey,
Help: "Cumulative number of hostprocess containers started. This metric will only be collected on Windows and requires WindowsHostProcessContainers feature gate to be enabled.",
Help: "Cumulative number of hostprocess containers started.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the This metric will only be collected on Windows bit still apply?

liggitt
liggitt reviewed May 1, 2023
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
for API doc change

/hold
one question about the metric docs, lgtm otherwise

pkg/kubelet/metrics/metrics.go Outdated
@@ -623,7 +623,7 @@ var (
&metrics.CounterOpts{
Subsystem: KubeletSubsystem,
Name: StartedHostProcessContainersErrorsTotalKey,
Help: "Cumulative number of errors when starting hostprocess containers. This metric will only be collected on Windows and requires WindowsHostProcessContainers feature gate to be enabled.",
Help: "Cumulative number of errors when starting hostprocess containers.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the This metric will only be collected on Windows bit still apply?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The metric will still only be collected on Windows nodes.
Let me update this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2023
@marosset
Removing WindowsHostProcessContainers feature-gate
ab9c8eb 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@marosset marosset force-pushed the remove-hostprocess-containers-featuregate branch from a42c4e0 to ab9c8eb Compare May 1, 2023 20:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2023
@liggitt
Copy link
Member

liggitt commented May 1, 2023

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 534b61d32c98faecf40355d480a559f39ce93b15

@k8s-ci-robot k8s-ci-robot merged commit 46852ca into kubernetes:master May 1, 2023
@honcao honcao mentioned this pull request Jan 3, 2024
Merged
8 tasks
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@dims dims Awaiting requested review from dims

@bart0sh bart0sh Awaiting requested review from bart0sh

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@liggitt liggitt Awaiting requested review from liggitt

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@dims dims

@mrunalp mrunalp

@jsturtevant jsturtevant

@liggitt liggitt

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node: code and documentation PRs
Archived in project
[sig-windows] PR tracking
Status: Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
10 participants
@marosset @k8s-triage-robot @bart0sh @k8s-ci-robot @jsturtevant @liggitt @dims @mrunalp @derekwaynecarr @dchen1107