-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSONPath template language #11738
JSONPath template language #11738
Conversation
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
`127.0.0.1 127.0.0.2 {cpu: 4} {cpu: 8}`}, | ||
{"range nodes capacity", "{range .items[*]}[{.metadata.name}, {.status.capacity}] {end}", nodesData, | ||
`[127.0.0.1, {cpu: 4}] [127.0.0.2, {cpu: 8}] `}, | ||
{"user passowrd", `{.users[?(@.name=="e2e")].user.password}`, nodesData, "secret"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry
LGTM. Please squash the commits. and then I will add 'lgtm' label and get this merged. |
@brendandburns Thanks. I squashed them into 8 commits. |
Sorry, I wasn't clear. Please squash to 1 commit. If there really are multiple conceptual things, they should be broken out as separate PRs (but I think it's fine for there to be one commit for this) Shippable appears to be a flake, I'm re-running. @k8s-bot test this please --brendan |
GCE e2e build/test passed for commit 8dcd077fb306ecf04cecda56fd5c280c79d2e38e. |
@brendandburns Thanks. There is only one commit now. |
LGTM, shippable is a flake, re-running. |
There is something severely borked in shippable. Its complaining about v1beta3, but there's nothing about v1beta3 in this PR. @k8s-bot test this please If this passes jenkins, I'm just going to merge it. |
GCE e2e build/test failed for commit 949704a. |
@k8s-bot test this please |
GCE e2e build/test failed for commit 949704a. |
@daizuozhuo I think it's a flake, I'm just going to merge this, and we'll see what happens... |
JSONPath template language
@daizuozhuo now that this is submitted, are you working on the integration with kubectl? We should create a new output format printer. Thanks! |
@brendanburns Yes, I will send pull request soon. |
/cc @pmorie re: expressiveness. |
Awesome work here guys, looking forward to this. Given this work, I'm going to stick to Go templating for now, instead of searching for some 3rd-party json pre-processor to fill in variables and the likes. ouch, spoke too soon, no Go templating support for |
@brendandburns Thanks. This is the rebased version of #9296