Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update gh/go.uber.org/{atomic,multierr} #117328

Merged
merged 2 commits into from
May 3, 2023
Merged

dependencies: update gh/go.uber.org/{atomic,multierr} #117328

merged 2 commits into from
May 3, 2023

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 14, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 14, 2023
@humblec humblec changed the title dependencies: update gh/go.uber.org/{atomic,zap,multierr} [wip] dependencies: update gh/go.uber.org/{atomic,zap,multierr} Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2023
@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2023

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 14, 2023
@humblec humblec changed the title [wip] dependencies: update gh/go.uber.org/{atomic,zap,multierr} dependencies: update gh/go.uber.org/{atomic,zap,multierr} Apr 14, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2023
@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2023

cc @liggitt @dims

liggitt
liggitt reviewed Apr 14, 2023
View reviewed changes
go.mod Outdated
@@ -75,7 +75,7 @@ require (
go.opentelemetry.io/otel/trace v1.10.0
go.opentelemetry.io/proto/otlp v0.19.0
go.uber.org/goleak v1.2.1
go.uber.org/zap v1.19.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main consumer of zap is the etcd client... the version of the etcd client we use tests with go.uber.org/zap v1.17.0

is there a reason to move further away from the version our etcd client tests with? is this fixing issues or just bumping to latest versions?

Copy link
Contributor Author

@humblec humblec Apr 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt its mostly a version bump , however the go min version has been updated in the dependencies along with other bug fixes ( as referenced in the PR description) . Agree that, the latest etcd client 3.5.8 make use of 1.17.0 , shall we keep the zap dependency untouched in this case?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about the dependency to know if matching versions more closely is important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serathius can you please share your thought about updating zap to 1.19.0 considering etcd client is the main consumer of this package? if its fine to use 1.19.0 we can update the same here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt zap is already on 1.19.0 in the master now. :), so this is good to go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt zap is already on 1.19.0 in the master now. :), so this is good to go.

are you referring to etcd master? looks like zap is at 1.24.0 now on etcd client master, but you also need to look at whether etcd had to adjust usage of zap when transitioning to newer versions of zap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt I was mentioning k/k dependency state https://github.com/kubernetes/kubernetes/blob/master/go.mod#L78

@fedebongio
Copy link
Contributor

/assign @liggitt
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 18, 2023
humblec added 2 commits April 26, 2023 14:02
@humblec
dependencies: update go.uber.org/multierr v1.11.0
8723057 
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@humblec
dependencies: go.uber.org/atomic v1.10.0
6da128b 
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2023
@humblec humblec changed the title dependencies: update gh/go.uber.org/{atomic,zap,multierr} dependencies: update gh/go.uber.org/{atomic,multierr} Apr 29, 2023
@humblec humblec requested a review from liggitt May 3, 2023 04:24
@liggitt
Copy link
Member

liggitt commented May 3, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 810313f1dbfe02765d9e3b3addd3eaa2a32c0f29

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit eea8086 into kubernetes:master May 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@humblec @fedebongio @liggitt @k8s-ci-robot