Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: update {vishvananda/netns,xlab/treeprint} #117327

Merged
merged 2 commits into from
May 2, 2023
Merged

dependencies: update {vishvananda/netns,xlab/treeprint} #117327

merged 2 commits into from
May 2, 2023

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 14, 2023 •
edited
Loading

/kind cleanup

NONE

humblec added 2 commits April 14, 2023 11:13
@humblec
dependencies: update netns to v0.0.4
6320b68 
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@humblec
dependencies: xlab/treeprint v1.2.0
6b70710 
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 14, 2023
@humblec humblec changed the title dependencies: update nettlink and tree print dependencies: update nets and tree print Apr 14, 2023
@humblec humblec changed the title dependencies: update nets and tree print dependencies: update netns and tree print Apr 14, 2023
@k8s-ci-robot k8s-ci-robot requested review from brianpursley, logicalhan and a team April 14, 2023 05:48
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/dependency Issues or PRs related to dependency changes area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2023
@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2023

cc @sig-cli-reviewers

@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2023

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 14, 2023
@akhilerm akhilerm mentioned this pull request Apr 14, 2023
Closed
@humblec humblec changed the title dependencies: update netns and tree print dependencies: update {vishvananda/netns,xlab/treeprint} Apr 14, 2023
@humblec
Copy link
Contributor Author

humblec commented Apr 14, 2023

cc @dims

BenTheElder
BenTheElder reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific improvements, bug fixes, breaking changes ...?
Why these two packages?

@humblec
Copy link
Contributor Author

humblec commented Apr 25, 2023 •
edited
Loading

Any specific improvements, bug fixes, breaking changes ...?

@BenTheElder mainly the (min) go version bump ( 1.17) in the dependency chain , no breaking changes afaict. also CI is green.

@humblec
Copy link
Contributor Author

humblec commented Apr 26, 2023

/triage accepted
/assign @soltysh

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 26, 2023
@humblec
Copy link
Contributor Author

humblec commented Apr 29, 2023 •
edited
Loading

/assign @dims

ps# #117241

@dims
Copy link
Member

dims commented Apr 29, 2023

changes are:

/assign @BenTheElder @liggitt

@liggitt
Copy link
Member

liggitt commented Apr 29, 2023

ps# #117241

this PR looks ~fine, but I'm curious what the relationship between this and the runc bump is?

@humblec
Copy link
Contributor Author

humblec commented May 2, 2023

ps# #117241

this PR looks ~fine, but I'm curious what the relationship between this and the runc bump is?

@liggitt just mentioning runc has this (gh/vishvananda/netns) dependency In the chain:
https://github.com/opencontainers/runc/blob/v1.1.6/go.mod#L32

@dims
Copy link
Member

dims commented May 2, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dc32d503e627292026b117ae571530b13f5f8f2f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0612001 into kubernetes:master May 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@brianpursley brianpursley Awaiting requested review from brianpursley

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dims dims

@soltysh soltysh

@BenTheElder BenTheElder

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
6 participants
@humblec @dims @liggitt @k8s-ci-robot @BenTheElder @soltysh