Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scheduler] Make sure handlers have synced before scheduling #116729

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[Scheduler] Make sure handlers have synced before scheduling #116729

merged 1 commit into from
Jun 28, 2023
+123 −31

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Mar 18, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Make sure handlers have finished syncing before the scheduling cycles start.

Which issue(s) this PR fixes:

Fixes #116717

Special notes for your reviewer:

This may not be a clean approach because it changes the return parameters for scheduler.New, and I am looking forward to finding some more clean solutions.

Does this PR introduce a user-facing change?

 schedular now waits for handlers to finish syncing before the scheduling cycles start.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 18, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 18, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 18, 2023
@AxeZhan AxeZhan force-pushed the handlers_sync branch 4 times, most recently from ccc5b03 to d14c5d1 Compare March 18, 2023 13:38
@AxeZhan
Copy link
Member Author

AxeZhan commented Mar 18, 2023

Current implementation returns a registeredHandlers []cache.ResourceEventHandlerRegistration for schedular.New, and pass this slice all the way to app.Run.
I think another option is to add a field registeredHandlers []cache.ResourceEventHandlerRegistration for schedular, and code changes will be cleaner, but will cost some more memories.
/cc @alculquicondor for some advice.

@AxeZhan AxeZhan changed the title WIP: [Scheduler] Make sure handlers have synced before scheduling [Scheduler] Make sure handlers have synced before scheduling Mar 18, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2023
@AxeZhan
Copy link
Member Author

AxeZhan commented Mar 18, 2023

Current implementation returns a registeredHandlers []cache.ResourceEventHandlerRegistration for schedular.New, and pass this slice all the way to app.Run. I think another option is to add a field registeredHandlers []cache.ResourceEventHandlerRegistration for schedular, and code changes will be cleaner, but will cost some more memories. /cc @alculquicondor for some advice.

/cc @alculquicondor

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2023
@AxeZhan
Copy link
Member Author

AxeZhan commented Mar 22, 2023

Current implementation returns a registeredHandlers []cache.ResourceEventHandlerRegistration for schedular.New, and pass this slice all the way to app.Run. I think another option is to add a field registeredHandlers []cache.ResourceEventHandlerRegistration for schedular, and code changes will be cleaner, but will cost some more memories. /cc @alculquicondor for some advice.

On a second thought, since we never break app.Run(). These handlers will never be garbage collected, so I've decided to use the later option.

@alculquicondor
Copy link
Member

storing sounds good.

/assign @denkensk
for first pass

@AxeZhan
Copy link
Member Author

AxeZhan commented May 30, 2023

kindly ping @aojea

@alculquicondor
Copy link
Member

ping @aojea

@AxeZhan AxeZhan force-pushed the handlers_sync branch 2 times, most recently from d412b0c to a0082b7 Compare June 20, 2023 12:23
@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33f44835a03f89bea51ec77b9a4efb2312f369b6

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 27, 2023
@aojea
Copy link
Member

aojea commented Jun 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, aojea, AxeZhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@AxeZhan
Copy link
Member Author

AxeZhan commented Jun 28, 2023

kindly ping @alculquicondor
This pr is rebased due to some conflict with master, we need a "lgtm" again :)

@chendave
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a64c783bdf4134448f0c5677a870191dae9615f2

@AxeZhan
Copy link
Member Author

AxeZhan commented Jun 28, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit ddbf357 into kubernetes:master Jun 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 28, 2023
This was referenced Aug 14, 2023
Merged
Closed
@RamezesDong RamezesDong mentioned this pull request Nov 5, 2023
Open
This was referenced Nov 15, 2023
Open
Closed
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerthcet kerthcet kerthcet left review comments

@denkensk denkensk Awaiting requested review from denkensk

@aojea aojea Awaiting requested review from aojea

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

@chendave chendave

@denkensk denkensk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Scheduler: Make sure handlers have synced before scheduling
7 participants
@AxeZhan @k8s-ci-robot @alculquicondor @denkensk @aojea @chendave @kerthcet