Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/Withdraw NetworkPolicy Status #115843

Merged
merged 3 commits into from
May 2, 2023
Merged

Remove/Withdraw NetworkPolicy Status #115843

merged 3 commits into from
May 2, 2023

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Feb 16, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind feature
/kind deprecation

What this PR does / why we need it:

sig-network has decided to not move forward with NetworkPolicyStatus feature. This PR removes the feature implemented in #107963

Which issue(s) this PR fixes:

Fixes kubernetes/enhancements#2943

Special notes for your reviewer:

I've added the comment with the previous protobuf name, lmk if this is fine :)

Does this PR introduce a user-facing change?

Remove withdrawn feature NetworkPolicyStatus

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP](https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2943-networkpolicy-status)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 16, 2023
@rikatz
Copy link
Contributor Author

rikatz commented Feb 16, 2023

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation area/network-policy Issues or PRs related to Network Policy subproject area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 16, 2023
@rikatz rikatz force-pushed the remote-netpol-status branch 2 times, most recently from 28ab43e to efb8a6f Compare February 16, 2023 18:44
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Feb 16, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sftim
Copy link
Contributor

sftim commented Feb 17, 2023 •
edited
Loading

For the changelog, do we actually mean:

Changed NetworkPolicy to always have an empty `.status` field

or something similar? Maybe we'd also mention that the feature gate is now deprecated and doesn't work, and that NetworkPolicies never have a status subresource.

@cici37
Copy link
Contributor

cici37 commented Feb 21, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 21, 2023
@liggitt
Copy link
Member

liggitt commented May 1, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2023
@rikatz
Copy link
Contributor Author

rikatz commented May 1, 2023

thanks @liggitt and @thockin

I will find someone to approve the testdata as this one apparently does need specific approval.

@rikatz
Copy link
Contributor Author

rikatz commented May 2, 2023

/cc @dims @johnbelamaric
for testdata approval

@k8s-ci-robot k8s-ci-robot requested review from dims and johnbelamaric May 2, 2023 00:00
@dims
Copy link
Member

dims commented May 2, 2023

/approve
/lgtm
/skip

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rikatz, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit d6471d0 into kubernetes:master May 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 2, 2023
@cici37
Copy link
Contributor

cici37 commented May 2, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2023
@riaankleinhans riaankleinhans mentioned this pull request May 2, 2023
Closed
@bertinatto bertinatto mentioned this pull request Jul 31, 2023
Merged
bertinatto added a commit to bertinatto/origin that referenced this pull request Aug 14, 2023
@bertinatto
Disable NetworkPolicyStatus tests
e4faffc 
Feature has been removed in Kubernetes 1.28: kubernetes/kubernetes#115843
@bertinatto bertinatto mentioned this pull request Aug 14, 2023
Merged
bertinatto added a commit to bertinatto/origin that referenced this pull request Aug 14, 2023
@bertinatto
Disable NetworkPolicyStatus tests
d527a85 
Feature has been removed in Kubernetes 1.28: kubernetes/kubernetes#115843
bertinatto added a commit to bertinatto/origin that referenced this pull request Aug 14, 2023
@bertinatto
Disable NetworkPolicyStatus tests
654d8e0 
Feature has been removed in Kubernetes 1.28: kubernetes/kubernetes#115843
bertinatto added a commit to bertinatto/origin that referenced this pull request Aug 14, 2023
@bertinatto
bump(k8s): disable NetworkPolicyStatus tests
00fb52f 
Feature has been removed in Kubernetes 1.28: kubernetes/kubernetes#115843
bertinatto added a commit to bertinatto/origin that referenced this pull request Aug 14, 2023
@bertinatto
bump(k8s): disable NetworkPolicyStatus tests
e91dc99 
Feature has been removed in Kubernetes 1.28: kubernetes/kubernetes#115843
@tklauser tklauser mentioned this pull request Aug 15, 2023
Merged
@mqasimsarfraz mqasimsarfraz mentioned this pull request Aug 16, 2023
Merged
bertinatto added a commit to bertinatto/origin that referenced this pull request Aug 16, 2023
@bertinatto
bump(k8s): disable NetworkPolicyStatus tests
0ebd98c 
Feature has been removed in Kubernetes 1.28: kubernetes/kubernetes#115843
@honcao honcao mentioned this pull request Jan 3, 2024
Merged
8 tasks
@sveinpj sveinpj mentioned this pull request Apr 26, 2024
Closed
5 tasks
@sveinpj sveinpj mentioned this pull request May 30, 2024
Closed
5 tasks
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@thockin thockin thockin left review comments

@liggitt liggitt liggitt left review comments

@danwinship danwinship danwinship left review comments

@abhiraut abhiraut Awaiting requested review from abhiraut

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@dims dims Awaiting requested review from dims

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@dims dims

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/network-policy Issues or PRs related to Network Policy subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

NetworkPolicy Status - Features and parsing
10 participants
@rikatz @k8s-triage-robot @sftim @cici37 @danwinship @k8s-ci-robot @aojea @thockin @liggitt @dims