Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Munge headerlines #11452

Merged
merged 3 commits into from
Jul 17, 2015
Merged

Munge headerlines #11452

merged 3 commits into from
Jul 17, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented Jul 17, 2015

No description provided.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit d9962eafbf74888cc4c80b1ab5db07097768ad4b.

@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

This fights with gendocs. Need to think about it (and this might happen on any such markdown-strictness fix)

@thockin thockin force-pushed the docs-munge-headerlines branch from d9962ea to 2b52678 Compare July 17, 2015 20:06
@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

fixed now

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 2b52678152a3f2fc5471c98c121351dde519babc.

@thockin thockin force-pushed the docs-munge-headerlines branch from 2b52678 to 8efa838 Compare July 17, 2015 20:50
@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

rebased

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test failed for commit 8efa838aa58a12ede8190f00750ce987edaaf760.

@bgrant0607 bgrant0607 added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 17, 2015
@bgrant0607 bgrant0607 added this to the v1.0 milestone Jul 17, 2015
@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 8efa838aa58a12ede8190f00750ce987edaaf760.

@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

all greennnnnn

bgrant0607
bgrant0607 reviewed Jul 17, 2015
View reviewed changes
docs/devel/development.md
# Option A: this will let your builds see packages that exist elsewhere on your system.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be applied to code blocks

@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

This catches code blocks. Dammit. Back to work

@thockin thockin force-pushed the docs-munge-headerlines branch from 8efa838 to 33f1862 Compare July 17, 2015 22:35
@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

Now bypasses code blocks

@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

@nikhiljindal you might want to follow this pattern or risk the same code-blocks problem

@bgrant0607
Copy link
Member

LGTM

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Jul 17, 2015
@bgrant0607
Copy link
Member

Passed verify-gendocs.sh
cc @davidopp please merge

davidopp added a commit that referenced this pull request Jul 17, 2015
@davidopp
Merge pull request #11452 from thockin/docs-munge-headerlines
d28a665 
Munge headerlines
@davidopp davidopp merged commit d28a665 into kubernetes:master Jul 17, 2015
@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 33f1862.

@lavalamp
Copy link
Member

LGTM

@thockin thockin deleted the docs-munge-headerlines branch July 27, 2015 15:12
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
@davidopp
Merge pull request kubernetes#11452 from thockin/docs-munge-headerlines
bc7325e 
Munge headerlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@thockin @k8s-bot @bgrant0607 @lavalamp @googlebot @davidopp