Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TOC munge include blank line before TOC #11448

Merged
merged 1 commit into from
Jul 17, 2015
Merged

Make TOC munge include blank line before TOC #11448

merged 1 commit into from
Jul 17, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented Jul 17, 2015

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test failed for commit b9a642c976b715a364d25a3aaf0a7d2e04661085.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 72bab5350384075b54cd39bf088fa5691092b6bc.

@lavalamp
Copy link
Member

LGTM

@lavalamp lavalamp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2015
@ArtfulCoder
Copy link
Contributor

Kicked shippable.

@bgrant0607 bgrant0607 added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 17, 2015
@bgrant0607
Copy link
Member

Failed run-gendocs.sh. Recommend rebase and re-munge.

@thockin
Copy link
Member Author

thockin commented Jul 17, 2015

rebased

@davidopp
Copy link
Member

@bgrant0607 says you need to rebase and re-run

@bgrant0607
Copy link
Member

Because we just added another doc

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 0424b9457102c1b24d250097bfb7e67eaed08bbc.

@davidopp
Copy link
Member

I won't merge anything else until this one goes in.

@bgrant0607
Copy link
Member

Travis passed already. It runs hack/run-gendocs.sh, so this can go in.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 6e4ec38.

@davidopp
Copy link
Member

ok if you say so :) merging now.

davidopp added a commit that referenced this pull request Jul 17, 2015
@davidopp
Merge pull request #11448 from thockin/docs-munges
ce6b137 
Make TOC munge include blank line before TOC
@davidopp davidopp merged commit ce6b137 into kubernetes:master Jul 17, 2015
@thockin thockin deleted the docs-munges branch July 27, 2015 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thockin @k8s-bot @lavalamp @ArtfulCoder @bgrant0607 @davidopp @googlebot