-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various minor edits/clarifications to docs/admin/ docs. #11438
Conversation
GCE e2e build/test passed for commit 17f27d408131ded9449f9d6ea7a15f03dae74d44. |
rebased |
GCE e2e build/test failed for commit 50aef855ded8ec6695d6cd314387878fd0008675. |
|
||
## Future enhancements (Networking) | ||
|
||
Per pod IP configuration is provider specific, so when making networking changes, its important to sand-box these as all providers may not use the same mechanisms (iptables, openvswitch, etc.) | ||
Per pod IP configuration is provider-specific, so when making networking changes, its important to sandbox these as all providers may not use the same mechanisms (iptables, openvswitch, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/its/it's/
GCE e2e build/test passed for commit 7f254452ea8a3bdae768fa9ad84df5f2ba88f10d. |
@@ -21,7 +21,7 @@ certainly want the docs that go with that version.</h1> | |||
|
|||
<!-- END MUNGE: UNVERSIONED_WARNING --> | |||
# Cluster Troubleshooting | |||
Most of the time, if you encounter problems, it is your application that is having problems. For application | |||
Most of the time, if you encounter problems, it is your application that is the root cause. For application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's... bold of us. I would remove this or qualify with a "and your cluster has been set up correctly and passed the conformance test" or some such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point, reworded.
Deleted docs/admin/namespaces.md as it was content-free and the topic is already covered well in docs/user-guide/namespaces.md
Since this was mostly grammar changes, I graded it pretty harshly ;) feel free to ignore some or all comments. I still think namespaces are primarily an admin concept, but it's a small enough detail that I'm not going to fight about it. |
GCE e2e build/test passed for commit 820c4cb. |
Implemented most suggestions, PTAL. The LimitRange/LimitRanger thing has been bugging me for a long time. We use it inconsistently all over the place. I decided not to try to fix it within this doc, but I agree we need to fix it at some point. |
GCE e2e build/test passed for commit d64250c. |
LGTM |
Various minor edits/clarifications to docs/admin/ docs.
Deleted docs/admin/namespaces.md as it was content-free and the topic is
already covered well in docs/user-guide/namespaces.md
@lavalamp