Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor edits/clarifications to docs/admin/ docs. #11438

Merged
merged 3 commits into from
Jul 17, 2015
Merged

Various minor edits/clarifications to docs/admin/ docs. #11438

merged 3 commits into from
Jul 17, 2015

Conversation

davidopp
Copy link
Member

Deleted docs/admin/namespaces.md as it was content-free and the topic is
already covered well in docs/user-guide/namespaces.md

@lavalamp

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 17f27d408131ded9449f9d6ea7a15f03dae74d44.

@davidopp davidopp closed this Jul 17, 2015
@davidopp davidopp reopened this Jul 17, 2015
@davidopp
Copy link
Member Author

rebased

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test failed for commit 50aef855ded8ec6695d6cd314387878fd0008675.


## Future enhancements (Networking)

Per pod IP configuration is provider specific, so when making networking changes, its important to sand-box these as all providers may not use the same mechanisms (iptables, openvswitch, etc.)
Per pod IP configuration is provider-specific, so when making networking changes, its important to sandbox these as all providers may not use the same mechanisms (iptables, openvswitch, etc.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/its/it's/

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 7f254452ea8a3bdae768fa9ad84df5f2ba88f10d.

@@ -21,7 +21,7 @@ certainly want the docs that go with that version.</h1>

<!-- END MUNGE: UNVERSIONED_WARNING -->
# Cluster Troubleshooting
Most of the time, if you encounter problems, it is your application that is having problems. For application
Most of the time, if you encounter problems, it is your application that is the root cause. For application
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's... bold of us. I would remove this or qualify with a "and your cluster has been set up correctly and passed the conformance test" or some such.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point, reworded.

David Oppenheimer added 2 commits July 17, 2015 10:53
Deleted docs/admin/namespaces.md as it was content-free and the topic is
already covered well in docs/user-guide/namespaces.md
@lavalamp
Copy link
Member

Since this was mostly grammar changes, I graded it pretty harshly ;) feel free to ignore some or all comments.

I still think namespaces are primarily an admin concept, but it's a small enough detail that I'm not going to fight about it.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 820c4cb.

@davidopp
Copy link
Member Author

Implemented most suggestions, PTAL.

The LimitRange/LimitRanger thing has been bugging me for a long time. We use it inconsistently all over the place. I decided not to try to fix it within this doc, but I agree we need to fix it at some point.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit d64250c.

@lavalamp
Copy link
Member

LGTM

@davidopp davidopp added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Jul 17, 2015
@davidopp davidopp closed this Jul 17, 2015
@davidopp davidopp reopened this Jul 17, 2015
davidopp added a commit that referenced this pull request Jul 17, 2015
Various minor edits/clarifications to docs/admin/ docs.
@davidopp davidopp merged commit 341f3a8 into kubernetes:master Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants