Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update coredns to v1.10.0 #114279

Merged
merged 3 commits into from
Dec 10, 2022
Merged

update coredns to v1.10.0 #114279

merged 3 commits into from
Dec 10, 2022
+67 −32

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Dec 5, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup feature

What this PR does / why we need it:

Example:

. {
  view example-view {
    expr incidr(client_ip(), '10.9.0.0/24')
  }
  forward . 10.9.0.100
}

. {
  forward . /etc/resolv.conf
}

Which issue(s) this PR fixes:

Fixes None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-up now includes CoreDNS version v1.9.3

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 5, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Dec 4 21:52:06 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Dec 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from bowei, dims and a team December 5, 2022 02:29
@k8s-ci-robot k8s-ci-robot added area/kubeadm area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 5, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Dec 5, 2022

/remove-area kubeadm

@pacoxu pacoxu changed the title update coredns to v1.10.0 [WIP]update coredns to v1.10.0 Dec 5, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2022
@pacoxu pacoxu mentioned this pull request Dec 5, 2022
Merged
@pacoxu pacoxu marked this pull request as draft December 5, 2022 03:44
neolit123
neolit123 reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
for kubeadm. thanks @pacoxu

@pacoxu pacoxu marked this pull request as ready for review December 6, 2022 18:28
@k8s-ci-robot k8s-ci-robot requested a review from cpanato December 6, 2022 18:28
@pacoxu pacoxu changed the title [WIP]update coredns to v1.10.0 update coredns to v1.10.0 Dec 6, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Dec 7, 2022

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 7, 2022
@dims
Copy link
Member

dims commented Dec 10, 2022

/retest

@dims
Copy link
Member

dims commented Dec 10, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit d2ed6d3 into kubernetes:master Dec 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 10, 2022
@liggitt liggitt modified the milestones: v1.26, v1.27 Dec 13, 2022
@pacoxu pacoxu mentioned this pull request Feb 13, 2023
Closed
@pacoxu pacoxu mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@bowei bowei Awaiting requested review from bowei

@dims dims Awaiting requested review from dims

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubeadm area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
5 participants
@pacoxu @k8s-ci-robot @dims @neolit123 @liggitt