Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Munge preformatted #11424

Merged
merged 4 commits into from
Jul 17, 2015
Merged

Munge preformatted #11424

merged 4 commits into from
Jul 17, 2015

Conversation

lavalamp
Copy link
Member

The first two commits are already in #11400.

@thockin

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 535e93d2b2f2dc8e468b87fdb45cc893a423f341.

@thockin
Copy link
Member

thockin commented Jul 17, 2015

LGTM for the sake of movement, but a couple things to touch back on.

@thockin
Copy link
Member

thockin commented Jul 17, 2015

We should probably munge the notPreformattedRE into simpler form: replace triple-ticks with single ticks when not a preformatted block (as a new munge step)

@thockin thockin added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Jul 17, 2015
@thockin
Copy link
Member

thockin commented Jul 17, 2015

fails Travis and shippable because of gendocs

@lavalamp lavalamp force-pushed the mungePreformatted branch from 535e93d to 683b839 Compare July 17, 2015 18:03
@lavalamp lavalamp force-pushed the mungePreformatted branch from 683b839 to f7873d2 Compare July 17, 2015 18:05
@lavalamp
Copy link
Member Author

Rebased, fixed comment. Will add test later.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 683b8390e027e3683aab6a954533b694886d8ed2.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test failed for commit f7873d2.

@lavalamp
Copy link
Member Author

Cluster creation timeout :/

@lavalamp
Copy link
Member Author

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit f7873d2.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test failed for commit 2c04668.

@davidopp
Copy link
Member

We decided to wait on this until all the other doc changes are merged. There are about 4 in testing right now.

@davidopp
Copy link
Member

@k8s-bot test this please

ArtfulCoder added a commit that referenced this pull request Jul 17, 2015
@ArtfulCoder
Merge pull request #11424 from lavalamp/mungePreformatted
816f18a 
Munge preformatted
@ArtfulCoder ArtfulCoder merged commit 816f18a into kubernetes:master Jul 17, 2015
@ArtfulCoder
Copy link
Contributor

OKed with Daniel and Brian to merge

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test failed for commit 2c04668.

@lavalamp lavalamp deleted the mungePreformatted branch August 26, 2015 20:04
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
@ArtfulCoder
Merge pull request kubernetes#11424 from lavalamp/mungePreformatted
3e224d6 
Munge preformatted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lavalamp @k8s-bot @thockin @davidopp @ArtfulCoder @googlebot