Add monitoring and healthz based on tunnel health. #11250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #11251 |
|
GCE e2e build/test passed for commit f80b02f74a80aa7fd1c5df9d7d090c8941bdb98e. |
|
I don't know the SSH logic well, but this changes seems plausible. |
|
LGTM, but @cjcullen who maybe has better context |
| } | ||
|
|
||
| m.lastSyncMetric = prometheus.NewGaugeFunc(prometheus.GaugeOpts{ |
There was a problem hiding this comment.
Should this be inside the above if block? I don't know prometheus well enough to know the implications, but this metric only makes sense in the ssh-tunnel case.
|
Updated to reflect offline conversation with @cjcullen move the metric inside the if ssh-tunnels block. ptal. |
|
GCE e2e build/test passed for commit b791948e2f179716a2cfd97a1f5345271a9c3037. |
|
GCE e2e build/test passed for commit 25d3834. |
|
Sorry, thought I had already. LGTM |
cjcullen
added
the
lgtm
|
I'm not merging any code until Jenkins is green for a turn. |
erictune
added a commit
that referenced
this pull request
Jul 15, 2015
Add monitoring and healthz based on tunnel health.
zmerlynn
added a commit
that referenced
this pull request
Jul 16, 2015
…-#11250-upstream-release-1.0 Automated cherry pick of #11250
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cjcullen @thockin
This is in response to some observed issues in GKE.