direct people to definitions.html to find out if a field is mutable #11184
Conversation
|
GCE e2e build/test failed for commit 8aec57ce1e21749f8d038079ae31307208111fc9. |
|
Navigating to the models is just too painful. Let's not do this until #10966 is done, and then link to that. |
caesarxuchao
force-pushed
the
patch-replace-doc
branch
from
8aec57c to
6dcd909
Compare
caesarxuchao
changed the title
|
I've updated the comment to direct people to check the definitions.html. Could someone review this? Thank you. |
|
GCE e2e build/test passed for commit 6dcd909eefc6cb13c86b8067ff1cb33c0cd19a0e. |
| JSON and YAML formats are accepted.` | ||
| JSON and YAML formats are accepted. | ||
|
|
||
| Please refer to the models in http://kubernetes.io/v1.0/docs/api-reference/definitions.html to find if a field is mutable.` |
There was a problem hiding this comment.
Shouldnt this be linked to HEAD here?
HEAD will be replaced by the appropriate version by versionize-docs.sh
There was a problem hiding this comment.
caesarxuchao
force-pushed
the
patch-replace-doc
branch
2 times, most recently
from
3f3450e to
5f9252a
Compare
| .PP | ||
| Please refer to the models in | ||
| \[la]https://htmlpreview.github.io/?https://github.com/GoogleCloudPlatform/kubernetes/HEAD/docs/api-reference/definitions.html\[ra] to find if a field is mutable. | ||
|
|
There was a problem hiding this comment.
@nikhiljindal updated to HEAD address.
|
@nikhiljindal, sorry for the long delay. I've updated the URL as requested. PTAL. Thank you! |
|
GCE e2e build/test passed for commit 5f9252ae1ceb1ff17447c8eaafac1c794daf9777. |
|
LGTM, thanks! |
nikhiljindal
added
the
lgtm
|
Looks like you need to run hack/run-gendocs.sh for travis and shippable to pass. |
caesarxuchao
force-pushed
the
patch-replace-doc
branch
from
5f9252a to
49d439b
Compare
|
GCE e2e build/test passed for commit 49d439b21cae51cf91b6e4e1c374da1f70bc4848. |
|
Shippable fails at verify-gendocs.sh, but the PR passes the script on my local machine. Close and reopen to trigger shippable and travis. |
|
Travis still complaining "/home/travis/gopath/src/github.com/GoogleCloudPlatform/kubernetes/docs/ is out of date. Please run hack/run-gendocs.sh" |
|
LGTM was before last commit, removing LGTM |
alex-mohr
added
lgtm
…d is mutable through kubectl replace/patch
caesarxuchao
force-pushed
the
patch-replace-doc
branch
from
49d439b to
17cd3cf
Compare
|
GCE e2e build/test passed for commit 17cd3cf. |
|
LGTM was before last commit, removing LGTM |
alex-mohr
added
lgtm
|
@k8s-bot test this [contrib/submit-queue: candidate for merging] |
|
GCE e2e build/test passed for commit 17cd3cf. |
|
Automatic merge from SubmitQueue |
direct people to definitions.html to find out if a field is mutable when doing a kubectl replace/patch;
add an example of
kubectl patchthat involves a merge key.fixes #11141
@nikhiljindal @mikedanese @bgrant0607