Remove mention of docker --bip flag. #11176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #11167 |
|
GCE e2e build/test passed for commit 92fc0cbf46d6a77b118b0fcd449a3fc9b1d95244. |
| @@ -336,7 +336,7 @@ brctl delbr docker0 | |||
|
|
|||
| The way you configure docker will depend in whether you have chosen the routable-vip or overlay-network approaches for your network. | |||
| Some docker options will want to think about: | |||
| - create your own bridge for the per-node CIDR ranges, and set `--bridge=cbr0` and `--bip=false`. Or let docker do it with `--bip=true`. | |||
| - create your own bridge for the per-node CIDR ranges, and set `--bridge=cbr0`. Or let docker do it with something like: `--bip=$NODE_X_POD_CIDR`. | |||
There was a problem hiding this comment.
I think mentioning --bip is more complex that simply documenting our cbr0 flag to kubelet and making those instructions good. For example, --bip assumes that docker0 does not exist, but if it does exist with a different IP, docker fails to start.
|
@thockin ptal |
erictune
changed the title
|
GCE e2e build/test passed for commit a6f795c075241d4f5fe66ea5e307fb0c2c162f30. |
| so that kube-proxy can manage iptables instead of docker. | ||
| - `--ip-masq=false` | ||
| - if you have setup PodIPs to be routable, then you want this false, otherwise, docker will | ||
| rewrite the PodIP source-address to a NodeIP. | ||
| - some environments (e.g. GCE) still need you to masquerade out-bound traffic when it leaves the cloud environment. This is very environment specific. | ||
| - if you are using an overlay network, consult those instructions. | ||
| - `--bip=` | ||
| - should be the CIDR range for pods for that specific node. |
|
PTAL |
thockin
added
lgtm
|
LGTM |
erictune
added
lgtm
|
GCE e2e build/test passed for commit 920eb5e0839558de40b5b16cd56df64c2d3b0840. |
|
GCE e2e build/test failed for commit 006d757. |
Closed
|
@k8s-bot test this please |
|
GCE e2e build/test passed for commit 006d757. |
davidopp
added a commit
that referenced
this pull request
Jul 17, 2015
Remove mention of docker --bip flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.