Make all docs have a warning if unversioned #11124
Conversation
|
GCE e2e build/test passed for commit 112ae11. |
thockin
force-pushed
the
docs-munge-branch-warnings_filter_munges
branch
from
112ae11 to
858f7b5
Compare
|
Given 3 people working on munges, I'd like to call dibs on not rebasing, since I am oncall today. |
|
Looks totally plausible. I didn't stare too long yet, though. |
|
GCE e2e build/test passed for commit 858f7b588416a8e17aded720647000429de2af99. |
|
LGTM |
erictune
added
the
lgtm
|
merge it! |
Mungedocs will keep this updated in head, and it will get stricken from releases.
All munges now start with `<!-- BEGIN MUNGE:` and end with `<!-- END MUNGE:`. This lets me (in a followup) filter them better to normalize contents during verification of generated docs.
This allows us to apply content-mutating munges to generated files and nothave the verifier flag them as needing regeneration later.
|
need rebase |
thockin
force-pushed
the
docs-munge-branch-warnings_filter_munges
branch
from
858f7b5 to
fffc64e
Compare
…ter_munges Make all docs have a warning if unversioned
|
merged |
|
GCE e2e build/test passed for commit fffc64e. |
|
This PR contains changes to build/mark-new-version which havent been cherrypicked to 1.0. |
|
not intended, can you handle it? On Mon, Jul 20, 2015 at 1:40 PM, Nikhil Jindal notifications@github.com
|
|
Yes. Am handling it |
Use mungedocs to insert a header on every .md file that screams "This is an unversioned doc!". Examples are not covered yet, since we don't run mungedocs on examples, but I will add that.
Suggest reviewing commit-by-commit. They might make a bit more sense in a different order but it was not worth the effort to rejigger.
@lavalamp - no more running mungedocs on TMP_DOCROOT - yay!
@brendandburns @zmerlynn