CRI: Add Windows Podsandbox Stats #110754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/XXL
|
/assign @dchen1107 @derekwaynecarr |
k8s-ci-robot
added
the
needs-rebase
jsturtevant
force-pushed
the
cri-stats-windows
branch
from
f7b6d1c to
d0a9667
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
Given hyper-v containers will be supported in Containerd through CRI fairly soon, we'll need to see if we can find a nice intersection with the stats that make sense for containers (and we're using the same for the pod sandbox it seems) and the VM. For Windows for memory it seems like we only ever fill in the workingset for memory and leave the rest blank https://github.com/containerd/containerd/blob/7eae7f206ca04fe32ab05cab760bb39fb1fcf2c7/pkg/cri/server/container_stats_list_windows.go#L78 |
|
The hyperv stats collected for the VM are https://github.com/microsoft/hcsshim/blob/master/cmd/containerd-shim-runhcs-v1/stats/stats.proto#L47-L70 |
|
/milestone v1.25 |
jsturtevant
force-pushed
the
cri-stats-windows
branch
from
b6ce850 to
6ec5588
Compare
Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
cri-stats-windows
branch
from
6ec5588 to
295a975
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
17 tasks
mansikulkarni96
added a commit
to mansikulkarni96/kubernetes
that referenced
this pull request
May 1, 2023
Part of kubernetes/enhancements#2371 Follow up to the initial work introducing CRI API fields for Windows metrics collection kubernetes#110754 Windows equivalent work for adding support for Windows podAndContainerStatsFromCRI kubernetes#103095, which will allow users to get Windows pod and container stats only from CRI. Signed-off-by: mansikulkarni96 <mankulka@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds fields to the cri api for Windows to collect metrics from the Container runtime.
Part of kubernetes/enhancements#2371
Follow up to the initial commit that added Linux stats #102789
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig node
/sig windows
/cc @dcantah @haircommander @bobbypage @marosset