Assigned emptyDir for etcd data dir in skydns pod #11055
Conversation
|
@bprashanth @dchen1107 |
|
GCE e2e build/test failed for commit 4e3db347bd41c5b378d1e0a12ffb67eb67a372b1. |
|
The 3 tests that are failing in this e2e are failing already in all the k8s bot runs for other in-flight PRs. |
| @@ -28,12 +28,17 @@ spec: | |||
| memory: 50Mi | |||
| command: | |||
| - /usr/local/bin/etcd | |||
| - -data-dir | |||
| - /var/etcd/data | |||
There was a problem hiding this comment.
this is a subdir of the volumeMount - is that intentional?
There was a problem hiding this comment.
I have now mounted mounted emptydir on /var/etcd/data
I used that as a mount mount for consistency. Our other etcd container on master uses /var/etcd/data
|
LGTM |
|
@jnagal for priority merge once @bprashanth OKs |
| - -listen-client-urls | ||
| - http://127.0.0.1:2379,http://127.0.0.1:4001 | ||
| - -advertise-client-urls | ||
| - http://127.0.0.1:2379,http://127.0.0.1:4001 | ||
| - -initial-cluster-token | ||
| - skydns-etcd | ||
| volumeMounts: |
There was a problem hiding this comment.
optional nit: etcd logs would also be nice
There was a problem hiding this comment.
I will have to wrap the etcd command in a shell for stdout and stderr to be redirected. I can do it in a separate PR
There was a problem hiding this comment.
don't redirect stdout/err - then 'kubectl logs` won't work
On Fri, Jul 10, 2015 at 8:59 AM, Abhi Shah notifications@github.com wrote:
In cluster/addons/dns/skydns-rc.yaml.in
#11055 (comment)
:- -listen-client-urls - http://127.0.0.1:2379,http://127.0.0.1:4001 - -advertise-client-urls - http://127.0.0.1:2379,http://127.0.0.1:4001 - -initial-cluster-token - skydns-etcd
volumeMounts:I will have to wrap the etcd command in a shell for stdout and stderr to
be redirected. I can do it in a separate PR—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/11055/files#r34368610
.
There was a problem hiding this comment.
I guess I just want -debug https://github.com/coreos/etcd/blob/master/Documentation/configuration.md, but it looks like it isn't available in etcd 2.0 :\
|
LGTM sans the volumeMount point. Also can you please wait for #11004 and rebase? :) |
ArtfulCoder
force-pushed
the
etcd_mount
branch
2 times, most recently
from
68dfed8 to
cebf233
Compare
thockin
added
lgtm
|
marked ok to merge |
|
GCE e2e build/test failed for commit 68dfed865f506a85fad020fb4de8ffd4531310bd. |
|
GCE e2e build/test passed for commit cebf23321d4017621e143552fcee0843b1a79c33. |
|
#11004 merged. Can you rebase? |
|
@rjnagal rebased |
|
@ArtfulCoder ASAP please On Fri, Jul 10, 2015 at 9:26 AM, Rohit Jnagal notifications@github.com
|
|
LGTM still, thanks |
|
merging |
|
Rohit is waiting for e2e |
|
GCE e2e build/test passed for commit bc99a57. |
Assigned emptyDir for etcd data dir in skydns pod
|
passed and merged. |
@thockin