modified spark example to use kubectl exec to interact with cluster a… #11047

gurvindersingh · 2015-07-10T09:22:22Z

…nd create spark driver pod

You can change the repo in the driver spec file to gcr.io, once the pull request is accepted and docker image pushed to official repository.

…nd create spark driver pod

googlebot · 2015-07-10T09:22:25Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

k8s-bot · 2015-07-10T09:23:05Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

gurvindersingh · 2015-07-10T09:25:42Z

I signed it!

brendandburns · 2015-07-22T20:50:28Z

@gurvindersingh
I don't see you in our CLA records, what email did you use?

We also moved a bunch of docs in the lead up to 1.0, you may need to recreate this PR. Sorry!

gurvindersingh · 2015-07-23T11:09:33Z

@brendandburns I have used this email address to sign the CLA gurvindersinghdahiya@gmail.com let me know if you can find, otherwise I can give it another try to sign. I will create/rebase the PR to the current master.

brendandburns · 2015-07-25T02:59:58Z

CLA verified. I think you need to associate your email with your github (or add your github to clasigners) in order for this to be automated.

Needs a rebase.

brendandburns · 2015-07-25T03:00:55Z

examples/spark/spark-driver.json

@@ -0,0 +1,23 @@
+{


any chance you can convert this to YAML instead of JSON?

All other specs in spark example are also in JSON, so should I convert all to YAML or leave as it is. I see there are few examples which have specs in YAML and whereas others in JSON. So any policy towards specs format ?

Preference for YAML. If you'd rather defer to a different PR, that's fine.

I will send another pull request which will converting all the JSON spec files in spark example to YAML

gurvindersingh · 2015-07-25T19:05:31Z

Rebased and addressed comment about indent, regarding JSON -> YAML.. will wait for @brendandburns reply.

googlebot · 2015-07-25T19:16:18Z

CLAs look good, thanks!

and fixed the email address issue

brendandburns · 2015-07-27T20:51:58Z

examples/spark/images/driver/start.sh

@@ -0,0 +1,9 @@
+#!/bin/bash


you need to add standard copyright boilerplate here.

brendandburns · 2015-07-27T20:52:16Z

Need copyright boilerplate on start.sh otherwise, LGTM.

gurvindersingh · 2015-07-27T21:07:46Z

added copyright boilerplate on start.sh

brendandburns · 2015-07-29T20:11:45Z

You need to run ./hack/run-gendocs.sh

(sorry for the complexity!)

gurvindersingh · 2015-07-29T20:59:30Z

i ran ./hack/run-gendocs.shand committed the changes to pull request. let me know if anything more is needed.

brendandburns · 2015-07-30T17:00:46Z

LGTM, thanks!

modified spark example to use kubectl exec to interact with cluster a…

ixdy · 2015-08-03T19:46:26Z

This test is failing continuously on GCE Jenkins.

INFO: Running '/jenkins-master-data/jobs/kubernetes-e2e-gce-examples/workspace/kubernetes/platforms/linux/amd64/kubectl --server=https://130.211.183.151 --kubeconfig=/var/lib/jenkins/jobs/kubernetes-e2e-gce-examples/workspace/.kube/config log spark-driver spark-driver --namespace=e2e-tests-examples-ou9nm'
INFO: 
[AfterEach] Examples e2e
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/examples.go:69
STEP: Destroying namespace for this suite e2e-tests-examples-ou9nm

• Failure [538.277 seconds]
Examples e2e
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/examples.go:528
  [Skipped][Example]Spark
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/examples.go:203
    should start spark master, driver and workers [It]
    /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/examples.go:202

    Expected error:
        <*errors.errorString | 0xc2082656a0>: {
            s: "Failed to find \"Starting Spark driver at\", last result: \"\"",
        }
        Failed to find "Starting Spark driver at", last result: ""
    not to have occurred

    /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/examples.go:193

Full build log/artifacts from a recent run are available here: https://cloud.google.com/console/storage/kubernetes-jenkins/logs/kubernetes-e2e-gce-examples/465/

modified spark example to use kubectl exec to interact with cluster a…

a046fa4

…nd create spark driver pod

googlebot added the cla: no label Jul 10, 2015

krousey added this to the v1.0-post milestone Jul 20, 2015

brendandburns self-assigned this Jul 22, 2015

bgrant0607 removed this from the v1.0-post milestone Jul 24, 2015

brendandburns added cla: yes and removed cla: no labels Jul 25, 2015

brendandburns added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2015

brendandburns reviewed Jul 25, 2015
View reviewed changes

fixed conflict with the current upstream master

a585357

googlebot added cla: no and removed cla: yes labels Jul 25, 2015

Gurvinder Singh and others added 3 commits July 25, 2015 21:05

added indent for sleep

68f0db8

fixed conflict with the current upstream master

2a6546c

added indent for sleep

5f48898

googlebot added cla: yes and removed cla: no labels Jul 25, 2015

Merge branch 'master' of https://github.com/gurvindersingh/kubernetes

df3ee69

and fixed the email address issue

brendandburns reviewed Jul 27, 2015
View reviewed changes

examples/spark/images/driver/start.sh

@@ -0,0 +1,9 @@

#!/bin/bash

Copy link

Contributor

brendandburns Jul 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add standard copyright boilerplate here.

added standard copyright

5599d83

fixed documentations after running gendocs.sh

f64d89f

added test for spark driver too

e1d76d5

brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 30, 2015

brendandburns added a commit that referenced this pull request Jul 30, 2015

Merge pull request #11047 from gurvindersingh/master

1d9a062

modified spark example to use kubectl exec to interact with cluster a…

brendandburns merged commit 1d9a062 into kubernetes:master Jul 30, 2015

gurvindersingh unassigned brendandburns Aug 12, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modified spark example to use kubectl exec to interact with cluster a… #11047

modified spark example to use kubectl exec to interact with cluster a… #11047

gurvindersingh commented Jul 10, 2015

googlebot commented Jul 10, 2015

k8s-bot commented Jul 10, 2015

gurvindersingh commented Jul 10, 2015

brendandburns commented Jul 22, 2015

gurvindersingh commented Jul 23, 2015

brendandburns commented Jul 25, 2015

brendandburns Jul 25, 2015

gurvindersingh Jul 25, 2015

brendandburns Jul 27, 2015

gurvindersingh Jul 27, 2015

gurvindersingh commented Jul 25, 2015

googlebot commented Jul 25, 2015

brendandburns Jul 27, 2015

brendandburns commented Jul 27, 2015

gurvindersingh commented Jul 27, 2015

brendandburns commented Jul 29, 2015

gurvindersingh commented Jul 29, 2015

brendandburns commented Jul 30, 2015

ixdy commented Aug 3, 2015

modified spark example to use kubectl exec to interact with cluster a… #11047

modified spark example to use kubectl exec to interact with cluster a… #11047

Conversation

gurvindersingh commented Jul 10, 2015

googlebot commented Jul 10, 2015

k8s-bot commented Jul 10, 2015

gurvindersingh commented Jul 10, 2015

brendandburns commented Jul 22, 2015

gurvindersingh commented Jul 23, 2015

brendandburns commented Jul 25, 2015

brendandburns Jul 25, 2015

Choose a reason for hiding this comment

gurvindersingh Jul 25, 2015

Choose a reason for hiding this comment

brendandburns Jul 27, 2015

Choose a reason for hiding this comment

gurvindersingh Jul 27, 2015

Choose a reason for hiding this comment

gurvindersingh commented Jul 25, 2015

googlebot commented Jul 25, 2015

brendandburns Jul 27, 2015

Choose a reason for hiding this comment

brendandburns commented Jul 27, 2015

gurvindersingh commented Jul 27, 2015

brendandburns commented Jul 29, 2015

gurvindersingh commented Jul 29, 2015

brendandburns commented Jul 30, 2015

ixdy commented Aug 3, 2015