Mark GCE as passing conformance test. #10995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test failed for commit 30fe02d. |
|
jenkins was a build timeout. |
| -------------------- | ------------ | ------ | ---------- | ------------------------------------------------------------------------------ | ----------- | ---------------------------- | ----- | ||
| GKE | | | GCE | [docs](https://cloud.google.com/container-engine) | | Commercial | Uses K8s version 0.15.0 | ||
| GKE | | | GCE | [docs](https://cloud.google.com/container-engine) | [✓](1) | Commercial | Uses K8s version 0.15.0 |
There was a problem hiding this comment.
Why indirect through the footnote? Why not just link directly?
There was a problem hiding this comment.
- so that the column just reads as either a checkmark or not. More visual impact
- to limit column width so it fits on screen, both rendered, and in text mode.
There was a problem hiding this comment.
Oh, I guess only reason 2b is valid: so that the text version of the md has reasonable line length.
|
LGTM |
lavalamp
added
the
lgtm
|
@thockin docs only change: okay to merge? |
thockin
added a commit
that referenced
this pull request
Jul 13, 2015
Mark GCE as passing conformance test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.