Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: Add $GOPATH to hack/update-generated-xxx.sh scripts #10987

Merged
merged 1 commit into from
Jul 10, 2015
Merged

hack: Add $GOPATH to hack/update-generated-xxx.sh scripts #10987

merged 1 commit into from
Jul 10, 2015

Conversation

stefwalter
Copy link
Contributor

So that not everyone has to figure this out.

@k8s-bot
Copy link

k8s-bot commented Jul 9, 2015

GCE e2e build/test passed for commit c1bb7030db4c6cd8a60b73936d51ee3c4c0beff4.

wojtek-t
wojtek-t reviewed Jul 9, 2015
View reviewed changes
hack/update-generated-deep-copies.sh
@@ -40,7 +45,7 @@ package ${version}
// AUTO-GENERATED FUNCTIONS START HERE
EOF

GOPATH=$(godep path):$GOPATH go run cmd/gendeepcopy/deep_copy.go -v ${version} -f - -o "${version}=" >> $TMPFILE
GOPATH=$(godep path):${GOPATH:=} go run cmd/gendeepcopy/deep_copy.go -v ${version} -f - -o "${version}=" >> $TMPFILE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the above script so that it's exactly the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this erroneous change. The others should be enough.

@stefwalter
hack: Add $GOPATH to hack/update-generated-xxx.sh scripts
a38a148 
So that not everyone has to figure this out.
@stefwalter stefwalter force-pushed the setup-golang-update-hack branch from c1bb703 to a38a148 Compare July 10, 2015 07:48
@wojtek-t
Copy link
Member

LGTM

@wojtek-t
Copy link
Member

cc @davidopp for lead LGTM

@wojtek-t wojtek-t assigned davidopp and unassigned wojtek-t Jul 10, 2015
@k8s-bot
Copy link

k8s-bot commented Jul 10, 2015

GCE e2e build/test failed for commit a38a148.

@wojtek-t
Copy link
Member

jenkins failure is unrelated to these changes:
Test Result (1 failure / -4)
Kubernetes e2e suite.Addon update should propagate add-on file changes

@wojtek-t
Copy link
Member

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Jul 10, 2015

GCE e2e build/test failed for commit a38a148.

@wojtek-t
Copy link
Member

Cluster didn't started.

@wojtek-t
Copy link
Member

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Jul 10, 2015

GCE e2e build/test failed for commit a38a148.

@davidopp
Copy link
Member

LGTM

Jenkins failures are not related to this PR. I'll re-run anyway but this is OK to merge.

@davidopp davidopp added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Jul 10, 2015
@davidopp
Copy link
Member

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Jul 10, 2015

GCE e2e build/test passed for commit a38a148.

rjnagal added a commit that referenced this pull request Jul 10, 2015
@rjnagal
Merge pull request #10987 from stefwalter/setup-golang-update-hack
869df32 
hack: Add $GOPATH to hack/update-generated-xxx.sh scripts
@rjnagal rjnagal merged commit 869df32 into kubernetes:master Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stefwalter @k8s-bot @wojtek-t @davidopp @googlebot @rjnagal