Add build-official-release.sh (take two)
#10910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @brendandburns (original) @ixdy @quinton-hoole |
|
GCE e2e build/test passed for commit 3bb2c776de5515cc0b1d771e6e683f90fe8458cf. |
|
The text for each release should include a link to docs and examples for that release: e.g. |
|
@thockin: Fixed in 79766ae5822d6dcca87ac8fde7fa8f9dfb8c09d8 |
|
GCE e2e build/test passed for commit 79766ae5822d6dcca87ac8fde7fa8f9dfb8c09d8. |
|
LGTM |
|
... but maybe squash before merge? |
This commit does 4 things: * Adds a script which will: (a) clone from a git tag, make release, and give you very detailed instructions as to what to do from that point. * Changes `push-official-release.sh` so we can't push "dirty" releases anymore (which `build-official-release.sh` also double checks at the end.) * Fixes kubernetes#9576 by ensuring a correct umask. * Changes common.sh to gtar all the way through, to ensure that bloody OS X tar never touches the release process, because I don't want to have to understand two tar programs and how release artifacts are created from both (c.f. kubernetes#10615.)
zmerlynn
force-pushed
the
redo_build_official_release
branch
from
79766ae to
d638604
Compare
|
Squashed. |
|
@brendandburns: Can we try to get this in ASAP, so I can break the world again while I'm still around? |
|
GCE e2e build/test passed for commit d638604. |
brendandburns
added
lgtm
|
LGTM + ok-to-merge |
|
cc @vmarmol .. I'll be watching |
brendandburns
added a commit
that referenced
this pull request
Jul 9, 2015
Add `build-official-release.sh` (take two)
zmerlynn
added a commit
to zmerlynn/kubernetes
that referenced
this pull request
Jul 9, 2015
This updates releasing.md with actual instructions on how to cut a release, leaving the theory section of that document alone. Along the way, I streamlined tiny bits of the existing process as I was describing them. The instructions are possibly pedantic, but should be executable by anyone at this point, versus taking someone versant in the dark arts. Relies on kubernetes#10910. Fixes kubernetes#1883.
xingzhou
pushed a commit
to xingzhou/kubernetes
that referenced
this pull request
Dec 15, 2016
This updates releasing.md with actual instructions on how to cut a release, leaving the theory section of that document alone. Along the way, I streamlined tiny bits of the existing process as I was describing them. The instructions are possibly pedantic, but should be executable by anyone at this point, versus taking someone versant in the dark arts. Relies on kubernetes#10910. Fixes kubernetes#1883.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of #10687:
Fixes kubernetes directory in release tarballs is not world-readable #9576 by ensuring a correct umask.
The two additional commits are fixes on top of #10687, to make it transparent what changed past the original PR.
Related to #1883.