Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook framework for cloud controller manager #108838

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Webhook framework for cloud controller manager #108838

merged 1 commit into from
Mar 15, 2023

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Mar 21, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

We need to allow cloud providers to host webhooks in their cloud controller managers in order to replace the persistent volume labeller admission controller that is currently present in the API server.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

See example usage here: kubernetes/cloud-provider-aws#321. I'll add a similar example to the example in cmd/cloud-controller-manager.go as well.

Does this PR introduce a user-facing change?

Added the ability to host webhooks in the cloud controller manager.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: [KEP-2699](https://github.com/kubernetes/enhancements/tree/master/keps/sig-cloud-provider/2699-add-webhook-hosting-to-ccm)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 21, 2022
@nckturner nckturner changed the title WIP Webhook framework WIP Webhook framework for cloud controller manager Mar 21, 2022
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 21, 2022
@nckturner nckturner mentioned this pull request Mar 21, 2022
Closed
@nckturner nckturner force-pushed the webhook-framework branch 3 times, most recently from 92e4a3f to 81fec57 Compare March 22, 2022 00:38
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023
@nckturner
Copy link
Contributor Author

/retest

@nckturner
Webhook framework for cloud controller manager
86f4136 
Provides framework for CCMs to host webhooks.
@nckturner
Copy link
Contributor Author

@cheftako for final LGTM

@nckturner
Copy link
Contributor Author

/retest

@dims
Copy link
Member

dims commented Mar 15, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f54d9af835995b9d5dba5f86d427ffb54177b087

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, dims, liggitt, nckturner, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset
Copy link
Contributor

@dims can you please update your review state to approved so this PR can merge?

@marosset
Copy link
Contributor

/test pull-kubernetes-unit
/test pull-kubernetes-unit

@marosset
Copy link
Contributor

/test pull-kubernetes-e2e-gce

@dims
Copy link
Member

dims commented Mar 15, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@dims
Copy link
Member

dims commented Mar 15, 2023 •
edited
Loading

/hold cancel

@dims dims self-requested a review March 15, 2023 00:57
@dims
Copy link
Member

dims commented Mar 15, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 15, 2023 •
edited
Loading

@nckturner: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-local-e2e 86f4136 link false /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit c072cae into kubernetes:master Mar 15, 2023
@twz123 twz123 mentioned this pull request Mar 17, 2023
Closed
11 tasks
This was referenced Aug 15, 2023
Closed
Closed
@apricote apricote mentioned this pull request Aug 18, 2023
Closed
@M4t7e M4t7e mentioned this pull request Aug 18, 2023
Merged
@kmala kmala mentioned this pull request Sep 26, 2023
Open
@aojea aojea mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@roycaihw roycaihw roycaihw left review comments

@liggitt liggitt liggitt left review comments

@cheftako cheftako cheftako left review comments

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@cheftako cheftako

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.