Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow KUBE_TEST_REPO_LIST to be a remote url as well #108429

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Allow KUBE_TEST_REPO_LIST to be a remote url as well #108429

merged 2 commits into from
Mar 2, 2022

Conversation

dims
Copy link
Member

@dims dims commented Mar 1, 2022 •
edited by k8s-ci-robot
Loading

KUBE_TEST_REPO_LIST originally was just a file path location. In this PR we add support so it could contain a remote url as well.

Why do we need this?
If you look at how this env var (pointing to a yaml file) is being used for example in:
https://github.com/kubernetes/test-infra/blob/e3b05747b13fa4c629fa96a8a3aa42b642ae1888/kubetest/aksengine.go#L1264-L1288

you will see that the yaml file is downloaded from the remote url and then saved into an intermediate file and then the KUBE_TEST_REPO_LIST is set to the location of file on disk. Let's just get rid of the intermediate step.

This will help

/kind cleanup

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow KUBE_TEST_REPO_LIST to be a remote url

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims
Allow KUBE_TEST_REPO_LIST to be a remote url as well
6f3765b 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 1, 2022
@k8s-ci-robot
Copy link
Contributor

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 1, 2022
@dims
Copy link
Member Author

dims commented Mar 1, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 1, 2022
@dims
Copy link
Member Author

dims commented Mar 1, 2022

/sig testing

/assign @BenTheElder @liggitt

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test labels Mar 1, 2022
@dims dims removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 1, 2022
@dims
Copy link
Member Author

dims commented Mar 1, 2022

/hold

for testing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022
@dims dims mentioned this pull request Mar 1, 2022
Merged
@dims
Copy link
Member Author

dims commented Mar 1, 2022

/retest

@dims
Copy link
Member Author

dims commented Mar 1, 2022

/test pull-kubernetes-e2e-gce-registry-sandbox

@dims
Copy link
Member Author

dims commented Mar 1, 2022

success! i can see the images for example here - https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/108429/pull-kubernetes-e2e-gce-registry-sandbox/1498758833965633536/artifacts/e2e-a416f0f6a0-667c4-minion-group-v5cc/images-containerd.log

@dims
Copy link
Member Author

dims commented Mar 1, 2022

(note only those images that are configured using the KUBE_TEST_REPO_LIST will be picked up from the alternate repos)

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022
@dims
Copy link
Member Author

dims commented Mar 1, 2022

/retest

@dims
Copy link
Member Author

dims commented Mar 2, 2022

/skip

@ameukam
Copy link
Member

ameukam commented Mar 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@dims
Copy link
Member Author

dims commented Mar 2, 2022

/test pull-kubernetes-e2e-gce-registry-sandbox

@dims
Copy link
Member Author

dims commented Mar 2, 2022

/hold

found an issue in https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/108429/pull-kubernetes-e2e-gce-registry-sandbox/1498856700180959232/artifacts/e2e-b064dc0206-667c4-master/kube-master-installation.log

Mar 02 03:30:11.999019 e2e-b064dc0206-667c4-master configure.sh[2128]: == Downloaded https://storage.googleapis.com/kubernetes-staging-474a5cca10/e2e-b064dc0206-667c4-devel/kubernetes-manifests.tar.gz (HASH = 1670625ec56e764d5f9bde222da5a69b78cc43ccb741a4d13756863155171ee4a41c88c1bc89900942bd54c09b87e1541b656fc15dc17e4e7db40a9fff984ef7) ==
Mar 02 03:30:12.012817 e2e-b064dc0206-667c4-master configure.sh[9376]: find: invalid expression; you have used a binary operator '-or' with nothing before it.
Mar 02 03:30:12.015270 e2e-b064dc0206-667c4-master configure.sh[9378]: sed: no input files

Looks like some well intentioned fixes broke things:
https://github.com/kubernetes/kubernetes/pull/90442/files#diff-dcbe601f5e14c1d9d805d0daf3629e02d1e1ea2be615f6e7f3036ca90a25c6e4R354-R357

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@dims
fix broken find command
08af993 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@dims
Copy link
Member Author

dims commented Mar 2, 2022

/test pull-kubernetes-e2e-gce-registry-sandbox

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 2, 2022
@dims
Copy link
Member Author

dims commented Mar 2, 2022

/retest

@palnabarun
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@dims
Copy link
Member Author

dims commented Mar 2, 2022

/hold cancel

pull-kubernetes-e2e-gce-registry-sandbox is now 💚

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@ameukam
Copy link
Member

ameukam commented Mar 2, 2022

/test pull-kubernetes-unit

@dims
Copy link
Member Author

dims commented Mar 2, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4737127 into kubernetes:master Mar 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 2, 2022
This was referenced Apr 16, 2022
Closed
Merged
@eddiezane
Copy link
Member

/release-note-edit

Allow KUBE_TEST_REPO_LIST to be a remote url

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 16, 2022
@eddiezane eddiezane mentioned this pull request Apr 18, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 28, 2022
@k8s-ci-robot
Merge pull request #109512 from eddiezane/automated-cherry-pick-of-#1…
f7005de 
…08429-upstream-release-1.23

Automated cherry pick of #108429: Allow KUBE_TEST_REPO_LIST to be a remote url as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag Awaiting requested review from mkumatag

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@BenTheElder BenTheElder

@liggitt liggitt

@ameukam ameukam

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
7 participants
@dims @k8s-ci-robot @ameukam @palnabarun @eddiezane @BenTheElder @liggitt