Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta #107329

Merged
merged 2 commits into from
Jul 29, 2022
Merged

promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta #107329

merged 2 commits into from
Jul 29, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 5, 2022 •
edited
Loading

This is an initial PR to promote the feature. I will use it to do some testing.
Once the KEP update kubernetes/enhancements#2697 is merged, then this PR will be ready for review.

kubernetes/enhancements#2697

Action Items:

/kind feature
Xrefs kubernetes/enhancements#1029

promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jan 5, 2022

/test pull-kubernetes-node-kubelet-serial
/test pull-kubernetes-node-e2e-containerd

@pacoxu pacoxu changed the title promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta [WIP]promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta Jan 28, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2022
@pacoxu pacoxu changed the title [WIP]promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta promote LocalStorageCapacityIsolationFSQuotaMonitoring to beta May 13, 2022
@pacoxu pacoxu marked this pull request as ready for review May 13, 2022 14:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2022
@pacoxu pacoxu force-pushed the promote-e2e-quota branch from 1f4b927 to 5c15c8d Compare May 13, 2022 14:34
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 13, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Jul 20, 2022

kindly ping @dchen1107 @mrunalp
for code freeze two weeks later

Would you approve this as the KEP is merged?

@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jul 21, 2022
Open
22 tasks
@pacoxu pacoxu mentioned this pull request Jul 26, 2022
Merged
@mrunalp
Copy link
Contributor

mrunalp commented Jul 28, 2022

/lgtm

@mrunalp
Copy link
Contributor

mrunalp commented Jul 28, 2022

/assign @dchen1107

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2022
@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 29, 2022 •
edited
Loading

@pacoxu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-kubelet-serial 1f4b927ecb33a9e83f932d5830c5e2f5b9c91adc link false /test pull-kubernetes-node-kubelet-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member Author

pacoxu commented Jul 29, 2022

/retest
/skip

@k8s-ci-robot k8s-ci-robot merged commit 95ed682 into kubernetes:master Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 29, 2022
@pacoxu pacoxu mentioned this pull request Aug 3, 2022
Merged
@rphillips rphillips mentioned this pull request Aug 26, 2022
Merged
@pacoxu pacoxu mentioned this pull request Aug 27, 2022
Closed
dghubble added a commit to poseidon/typhoon that referenced this pull request Aug 27, 2022
@dghubble
Disable LocalStorageCapacityIsolationFSQuotaMonitoring feature
34b8833 
* Kubernetes v1.25.0 moved the LocalStorageCapacityIsolationFSQuotaMonitoring
feature from alpha to beta, but it breaks Kubelet updating ConfigMaps in
Pods, as shown by conformance tests
* Kubernetes is rolling LocalStorageCapacityIsolationFSQuotaMonitoring back
to alpha so its not enabled by default, but that will require a release
* Disable the feature gate directly as a workaround for now to make
Kubernetes v1.25.0 usable

```
FailedMount: MountVolume.SetUp failed for volume "configmap-volume" : requesting quota on existing directory /var/lib/kubelet/pods/f09fae17-ff16-4a05-aab3-7b897cb5b732/volumes/kubernetes.io~configmap/configmap-volume but different pod 673ad247-abf0-434e-99eb-1c3f57d7fdaa a4568e94-2b2d-438f-a4bd-c9edc814e478
```

Rel:

* kubernetes/kubernetes#112076
* kubernetes/kubernetes#107329
dghubble added a commit to poseidon/typhoon that referenced this pull request Aug 27, 2022
@dghubble
Disable LocalStorageCapacityIsolationFSQuotaMonitoring feature
275fc0f 
* Kubernetes v1.25.0 moved the LocalStorageCapacityIsolationFSQuotaMonitoring
feature from alpha to beta, but it breaks Kubelet updating ConfigMaps in
Pods, as shown by conformance tests
* Kubernetes is rolling LocalStorageCapacityIsolationFSQuotaMonitoring back
to alpha so its not enabled by default, but that will require a release
* Disable the feature gate directly as a workaround for now to make
Kubernetes v1.25.0 usable

```
FailedMount: MountVolume.SetUp failed for volume "configmap-volume" : requesting quota on existing directory /var/lib/kubelet/pods/f09fae17-ff16-4a05-aab3-7b897cb5b732/volumes/kubernetes.io~configmap/configmap-volume but different pod 673ad247-abf0-434e-99eb-1c3f57d7fdaa a4568e94-2b2d-438f-a4bd-c9edc814e478
```

Rel:

* kubernetes/kubernetes#112076
* kubernetes/kubernetes#107329
@dghubble dghubble mentioned this pull request Aug 27, 2022
Merged
dghubble-robot pushed a commit to poseidon/terraform-azure-kubernetes that referenced this pull request Aug 27, 2022
@dghubble
Disable LocalStorageCapacityIsolationFSQuotaMonitoring feature
d71810b 
* Kubernetes v1.25.0 moved the LocalStorageCapacityIsolationFSQuotaMonitoring
feature from alpha to beta, but it breaks Kubelet updating ConfigMaps in
Pods, as shown by conformance tests
* Kubernetes is rolling LocalStorageCapacityIsolationFSQuotaMonitoring back
to alpha so its not enabled by default, but that will require a release
* Disable the feature gate directly as a workaround for now to make
Kubernetes v1.25.0 usable

```
FailedMount: MountVolume.SetUp failed for volume "configmap-volume" : requesting quota on existing directory /var/lib/kubelet/pods/f09fae17-ff16-4a05-aab3-7b897cb5b732/volumes/kubernetes.io~configmap/configmap-volume but different pod 673ad247-abf0-434e-99eb-1c3f57d7fdaa a4568e94-2b2d-438f-a4bd-c9edc814e478
```

Rel:

* kubernetes/kubernetes#112076
* kubernetes/kubernetes#107329
dghubble-robot pushed a commit to poseidon/terraform-digitalocean-kubernetes that referenced this pull request Aug 27, 2022
@dghubble
Disable LocalStorageCapacityIsolationFSQuotaMonitoring feature
33833d1 
* Kubernetes v1.25.0 moved the LocalStorageCapacityIsolationFSQuotaMonitoring
feature from alpha to beta, but it breaks Kubelet updating ConfigMaps in
Pods, as shown by conformance tests
* Kubernetes is rolling LocalStorageCapacityIsolationFSQuotaMonitoring back
to alpha so its not enabled by default, but that will require a release
* Disable the feature gate directly as a workaround for now to make
Kubernetes v1.25.0 usable

```
FailedMount: MountVolume.SetUp failed for volume "configmap-volume" : requesting quota on existing directory /var/lib/kubelet/pods/f09fae17-ff16-4a05-aab3-7b897cb5b732/volumes/kubernetes.io~configmap/configmap-volume but different pod 673ad247-abf0-434e-99eb-1c3f57d7fdaa a4568e94-2b2d-438f-a4bd-c9edc814e478
```

Rel:

* kubernetes/kubernetes#112076
* kubernetes/kubernetes#107329
dghubble-robot pushed a commit to poseidon/terraform-onprem-kubernetes that referenced this pull request Aug 27, 2022
@dghubble
Disable LocalStorageCapacityIsolationFSQuotaMonitoring feature
e9b6c84 
* Kubernetes v1.25.0 moved the LocalStorageCapacityIsolationFSQuotaMonitoring
feature from alpha to beta, but it breaks Kubelet updating ConfigMaps in
Pods, as shown by conformance tests
* Kubernetes is rolling LocalStorageCapacityIsolationFSQuotaMonitoring back
to alpha so its not enabled by default, but that will require a release
* Disable the feature gate directly as a workaround for now to make
Kubernetes v1.25.0 usable

```
FailedMount: MountVolume.SetUp failed for volume "configmap-volume" : requesting quota on existing directory /var/lib/kubelet/pods/f09fae17-ff16-4a05-aab3-7b897cb5b732/volumes/kubernetes.io~configmap/configmap-volume but different pod 673ad247-abf0-434e-99eb-1c3f57d7fdaa a4568e94-2b2d-438f-a4bd-c9edc814e478
```

Rel:

* kubernetes/kubernetes#112076
* kubernetes/kubernetes#107329
dghubble-robot pushed a commit to poseidon/terraform-aws-kubernetes that referenced this pull request Aug 27, 2022
@dghubble
Disable LocalStorageCapacityIsolationFSQuotaMonitoring feature
96ca485 
* Kubernetes v1.25.0 moved the LocalStorageCapacityIsolationFSQuotaMonitoring
feature from alpha to beta, but it breaks Kubelet updating ConfigMaps in
Pods, as shown by conformance tests
* Kubernetes is rolling LocalStorageCapacityIsolationFSQuotaMonitoring back
to alpha so its not enabled by default, but that will require a release
* Disable the feature gate directly as a workaround for now to make
Kubernetes v1.25.0 usable

```
FailedMount: MountVolume.SetUp failed for volume "configmap-volume" : requesting quota on existing directory /var/lib/kubelet/pods/f09fae17-ff16-4a05-aab3-7b897cb5b732/volumes/kubernetes.io~configmap/configmap-volume but different pod 673ad247-abf0-434e-99eb-1c3f57d7fdaa a4568e94-2b2d-438f-a4bd-c9edc814e478
```

Rel:

* kubernetes/kubernetes#112076
* kubernetes/kubernetes#107329
dghubble-robot pushed a commit to poseidon/terraform-google-kubernetes that referenced this pull request Aug 27, 2022
@dghubble
Disable LocalStorageCapacityIsolationFSQuotaMonitoring feature
46606f7 
* Kubernetes v1.25.0 moved the LocalStorageCapacityIsolationFSQuotaMonitoring
feature from alpha to beta, but it breaks Kubelet updating ConfigMaps in
Pods, as shown by conformance tests
* Kubernetes is rolling LocalStorageCapacityIsolationFSQuotaMonitoring back
to alpha so its not enabled by default, but that will require a release
* Disable the feature gate directly as a workaround for now to make
Kubernetes v1.25.0 usable

```
FailedMount: MountVolume.SetUp failed for volume "configmap-volume" : requesting quota on existing directory /var/lib/kubelet/pods/f09fae17-ff16-4a05-aab3-7b897cb5b732/volumes/kubernetes.io~configmap/configmap-volume but different pod 673ad247-abf0-434e-99eb-1c3f57d7fdaa a4568e94-2b2d-438f-a4bd-c9edc814e478
```

Rel:

* kubernetes/kubernetes#112076
* kubernetes/kubernetes#107329
@pacoxu pacoxu mentioned this pull request Sep 21, 2022
Closed
11 tasks
Snaipe pushed a commit to aristanetworks/monsoon that referenced this pull request Apr 13, 2023
@dghubble
Disable LocalStorageCapacityIsolationFSQuotaMonitoring feature
a7015b8 
* Kubernetes v1.25.0 moved the LocalStorageCapacityIsolationFSQuotaMonitoring
feature from alpha to beta, but it breaks Kubelet updating ConfigMaps in
Pods, as shown by conformance tests
* Kubernetes is rolling LocalStorageCapacityIsolationFSQuotaMonitoring back
to alpha so its not enabled by default, but that will require a release
* Disable the feature gate directly as a workaround for now to make
Kubernetes v1.25.0 usable

```
FailedMount: MountVolume.SetUp failed for volume "configmap-volume" : requesting quota on existing directory /var/lib/kubelet/pods/f09fae17-ff16-4a05-aab3-7b897cb5b732/volumes/kubernetes.io~configmap/configmap-volume but different pod 673ad247-abf0-434e-99eb-1c3f57d7fdaa a4568e94-2b2d-438f-a4bd-c9edc814e478
```

Rel:

* kubernetes/kubernetes#112076
* kubernetes/kubernetes#107329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@yujuhong yujuhong Awaiting requested review from yujuhong

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@mrunalp mrunalp

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@pacoxu @k8s-ci-robot @k8s-triage-robot @mrunalp @dchen1107