Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate dynamic log sanitization #107207

Merged
merged 2 commits into from
Jan 15, 2022
Merged

Deprecate dynamic log sanitization #107207

merged 2 commits into from
Jan 15, 2022

Conversation

ehashman
Copy link
Member

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Removes dynamic log sanitization feature.

Which issue(s) this PR fixes:

Addresses kubernetes/enhancements#1753

Special notes for your reviewer:

See kubernetes/enhancements#3096

Does this PR introduce a user-facing change?

ACTION REQUIRED: The experimental dynamic log sanitization feature has been deprecated and removed in the 1.24 release. The feature is no longer available for use.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: http://kep.k8s.io/1753

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Dec 23, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 23, 2021
@ehashman ehashman force-pushed the deprecate-log-sanitization branch from 04e50b9 to dbd50d9 Compare December 23, 2021 21:03
ehashman
ehashman commented Dec 23, 2021
View reviewed changes
vendor/modules.txt
@@ -1937,12 +1937,10 @@ k8s.io/component-base/configz
k8s.io/component-base/featuregate
k8s.io/component-base/featuregate/testing
k8s.io/component-base/logs
k8s.io/component-base/logs/datapol
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we still need the data policy tags for static analysis so I left them alone, but I believe this isn't being vendored directly into k8s anymore with the removal of log sanitization.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the data policy tags in, so they could be used to benefit static analysis, was the primary concern raised during the SIG Security meeting. Thank you for calling this out explicitly.

@ehashman
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 23, 2021
@tabbysable
Copy link
Member

/sig security
/lgtm

@k8s-ci-robot k8s-ci-robot added the sig/security Categorizes an issue or PR as relevant to SIG Security. label Dec 27, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2021
@PurelyApplied PurelyApplied mentioned this pull request Dec 28, 2021
Merged
@leilajal
Copy link
Contributor

leilajal commented Jan 4, 2022

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 4, 2022
@ehashman ehashman changed the title [WIP] Deprecate dynamic log sanitization Deprecate dynamic log sanitization Jan 5, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@dashpole
Copy link
Contributor

cc @vantuvt
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 13, 2022
@ehashman
Copy link
Member Author

/assign @liggitt

for top-level approval/final API pass

@liggitt
Copy link
Member

liggitt commented Jan 15, 2022

/approve
config API change lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 22a03f8 into kubernetes:master Jan 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 15, 2022
@ehashman ehashman deleted the deprecate-log-sanitization branch January 21, 2022 23:37
@ehashman ehashman mentioned this pull request Jan 21, 2022
Closed
@husky-parul husky-parul mentioned this pull request Mar 24, 2022
Merged
@ehashman ehashman mentioned this pull request Mar 25, 2022
Merged
@github-actions github-actions bot mentioned this pull request May 6, 2022
Open
@mrgiles mrgiles mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabbysable tabbysable tabbysable left review comments

@andyxning andyxning Awaiting requested review from andyxning

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@liggitt liggitt

@tabbysable tabbysable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/security Categorizes an issue or PR as relevant to SIG Security. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
7 participants
@ehashman @tabbysable @leilajal @k8s-triage-robot @dashpole @liggitt @k8s-ci-robot