Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix heapster google configs so that heapster has a CA cert for googleapis #10634

Merged
merged 1 commit into from
Jul 1, 2015

Conversation

mikedanese
Copy link
Member

Fixes #10617
cc @vishh @piosz

@piosz
Copy link
Member

piosz commented Jul 1, 2015

LGTM from me. Thanks @mikedanese for doing it. Could you please also fix kubernetes-retired/heapster#381 the same way to prevent from this bug in the future?

@k8s-bot
Copy link

k8s-bot commented Jul 1, 2015

GCE e2e build/test passed for commit 3b6e04eded18d16c48830e640496fceeb9e9a70e.

@k8s-bot
Copy link

k8s-bot commented Jul 1, 2015

GCE e2e build/test passed for commit 6ecddd9.

@mikedanese mikedanese added this to the v1.0 milestone Jul 1, 2015
@piosz
Copy link
Member

piosz commented Jul 1, 2015

@thockin @davidopp could you please take a look as Kubernetes leads?

@davidopp
Copy link
Member

davidopp commented Jul 1, 2015

LGTM

@dchen1107 would also be a good person to look at it

@dchen1107
Copy link
Member

LGTM

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2015
zmerlynn added a commit that referenced this pull request Jul 1, 2015
fix heapster google configs so that heapster has a CA cert for googleapis
@zmerlynn zmerlynn merged commit 30cc467 into kubernetes:master Jul 1, 2015
@mikedanese mikedanese deleted the fix-ca-logs branch July 1, 2015 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants