Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use debian-iptables:bullseye-v1.1.0 #106301

Merged
merged 1 commit into from
Nov 10, 2021
Merged

build: use debian-iptables:bullseye-v1.1.0 #106301

merged 1 commit into from
Nov 10, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Nov 10, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The newer image contains go-runner, which is relevant for removing the
deprecated klog flags in the kube-proxy image.

Which issue(s) this PR fixes:

Fixes ##106086

Special notes for your reviewer:

The new image first needs to be promoted before this PR can be merged.

Does this PR introduce a user-facing change?

The kube-proxy image contains /go-runner as a replacement for deprecated klog flags.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2845

@pohly
build: use debian-iptables:bullseye-v1.1.0
3cfef61 
The newer image contains go-runner, which is relevant for removing the
deprecated klog flags in the kube-proxy image.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

@pohly: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 10, 2021
@pohly pohly changed the title WIP: build: use debian-iptables:bullseye-v1.1.0 build: use debian-iptables:bullseye-v1.1.0 Nov 10, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@pohly
Copy link
Contributor Author

pohly commented Nov 10, 2021

/retest

New debian-iptables image should be available now.

@pohly
Copy link
Contributor Author

pohly commented Nov 10, 2021 •
edited
Loading

/cc @BenTheElder

This finishes the work on go-runner in debian-iptables + kube-proxy.

@pohly pohly mentioned this pull request Nov 10, 2021
Closed
26 tasks
BenTheElder
BenTheElder approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit fb3df2e into kubernetes:master Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 10, 2021
dghubble added a commit to poseidon/kubelet that referenced this pull request Nov 15, 2021
@dghubble
Update debian-iptables from v1.0.0 to v1.1.0
505f6ef 
* kubernetes/kubernetes#106301
@dghubble dghubble mentioned this pull request Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@mkumatag mkumatag Awaiting requested review from mkumatag

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@pohly @k8s-ci-robot @BenTheElder