Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string output format for secret validations #106179

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix string output format for secret validations #106179

merged 1 commit into from
Dec 8, 2021

Conversation

vivek-koppuru
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Continued from #103707, this aims to fix the error messaging that shows up for secret validations. Currently, the output is as follows when validation for basic auth secrets fail:

The Secret "secret-basic-auth" is invalid: 
* data[%s][username]: Required value
* data[%s][password]: Required value

With this PR, the output will be as follows:

The Secret "secret-basic-auth" is invalid: 
* data[username]: Required value
* data[password]: Required value

This will fix the format for the ssh auth secret as well.

Which issue(s) this PR fixes:

Fixes #

N/A

Special notes for your reviewer:

Let me know if I can do any other type of testing on my local machine apart from what is tested through Prow.

Does this PR introduce a user-facing change?

Not sure if this warrants a release note but it is as follows:

Fix bug in error messaging for basic-auth and ssh secret validations.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

@vivek-koppuru: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @vivek-koppuru. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2021
@vivek-koppuru
Copy link
Contributor Author

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Nov 5, 2021
@vivek-koppuru
Copy link
Contributor Author

@enj @liggitt What do you think, as we talked about this in a previous PR?

@liggitt
Copy link
Member

liggitt commented Dec 1, 2021

/ok-to-test
/lgtm
/approve
/milestone v1.24

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 1, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, vivek-koppuru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2021
@vivek-koppuru
Copy link
Contributor Author

Thanks for the approval @liggitt ! Since this is for milestone 1.24, this won't be merged until it is created for that based on the tide message? Will I need to keep track of this PR at a later time for potential merge conflicts?

@liggitt
Copy link
Member

liggitt commented Dec 1, 2021 •
edited
Loading

Since this is for milestone 1.24, this won't be merged until it is created for that based on the tide message?

This will merge once master reopens for 1.24 (in ~1 week).

Will I need to keep track of this PR at a later time for potential merge conflicts?

I wouldn't expect anything to touch this file between now and master reopening, but yeah, if there's a merge conflict, it'll need rebasing

@k8s-ci-robot k8s-ci-robot merged commit a90f31f into kubernetes:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta Awaiting requested review from fejta

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
3 participants
@vivek-koppuru @k8s-ci-robot @liggitt