Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

I signed it!

CLAs look good, thanks!

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

Is this all you needed to do - update the AMIs and versions?

Oh, wow, I just noticed the super-confusion in the Getting Started Guide directory. There's this file, which as far as I can tell isn't linked to from https://github.com/GoogleCloudPlatform/kubernetes/tree/master/docs/getting-started-guides . And then there's the entire CoreOS family, which is linked to from the table. cc @erictune because confused.

Anyways, in general this LGTM if it works for you - I'm not trying to cause friction. We can open a separate issue for sorting out the rest.

Assigning to @erictune in case there's anything about the directory pieces he wants to handle, and for other review, etc.

@zmerlynn yeah, as a n00b, the AWS docs were kind of all over the place, but not so bad I couldn't find them. I ended up making at Terraform based setup using the YAML cloud-configs and it seems to work fine now.

waiting on Eric's final review

Thanks for updating. LGTM

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

ok to test

GCE e2e build/test passed for commit b043be5a190d17f7fda36c268d50a93c76ddeef0.

• Build Log
• Test Artifacts
• Internal Jenkins Results

needs rebase.

GCE e2e build/test passed for commit 45d0966e956a3b32b4d36b4e493dec7046c3377d.

• Build Log
• Test Artifacts
• Internal Jenkins Results

You did a merge. I was looking for a rebase.
At this point, you could do something like the following in your git client.

• git rebase -i HEAD~2 and delete the line that says "Merge branch upstream_master".
• git fetch upstream
• git rebase upstream/master

See Git Setup in docs/devel/development.md

https://github.com/chiefy/tf-aws-kubernetes looks pretty cool, by the way.

@erictune I was getting conflicts on my rebase I didn't feel comfortable with... will try again, sorry.

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-bot ok to test

GCE e2e build/test passed for commit 5673584.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Thanks for this contribution. I'm happy to merge it.

At some point in the future, I'd like to understand:

• does this file really need to use kube-register now that kubelets support self-registration?
• I can't tell if you are the only one using this file. If so, it might make sense to move it to your repo.

LGTM

@erictune I know very little about Kubernetes, I consider myself a n00b. I was interested to investigate using it, and I love using Terraform to standup AWS infrastructure as it's much easier than using the console (IMO). So I basically came to the wiki looking for info on how to use Kubernetes w/ AWS. I would be more than happy to keep my TF project updated vs. here if you want to somehow link it from the wiki. I very well might be the only person using the cloud-init examples, so it may make sense for me to keep them updated.

I will definitely look into deprecating the use of kube-register when I get some time!

Thanks!