Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed extraneous json descriptions from internal types #10566

Merged
merged 1 commit into from
Jul 1, 2015
Merged

Removed extraneous json descriptions from internal types #10566

merged 1 commit into from
Jul 1, 2015
+19 −19

Conversation

markturansky
Copy link
Contributor

Internal types do not require description but several still had them.

@bgrant0607 @nikhiljindal

@k8s-bot
Copy link

k8s-bot commented Jun 30, 2015

GCE e2e build/test passed for commit c39be4b.

@zmerlynn
Copy link
Member

zmerlynn commented Jul 1, 2015

Over to @bgrant0607.

@bgrant0607
Copy link
Member

Thanks. LGTM

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2015
@bgrant0607 bgrant0607 assigned lavalamp and unassigned bgrant0607 Jul 1, 2015
@bgrant0607
Copy link
Member

Reassign to @lavalamp for another LGTM

@nikhiljindal
Copy link
Contributor

LGTM

@lavalamp
Copy link
Member

lavalamp commented Jul 1, 2015

LGTM

Sure-- can we take the json tags out, too? :) :) In a follow-up.

@bgrant0607
Copy link
Member

@lavalamp Removing json tags didn't work last time we tried. That's #3933. However, at this point I think the best solution is to nuke api/types.go entirely.

zmerlynn added a commit that referenced this pull request Jul 1, 2015
@zmerlynn
Merge pull request #10566 from markturansky/pvspec_desc
0edd827 
Removed extraneous json descriptions from internal types
@zmerlynn zmerlynn merged commit 0edd827 into kubernetes:master Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@markturansky @k8s-bot @zmerlynn @bgrant0607 @nikhiljindal @lavalamp @googlebot