Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.17] Update to go1.17.2 #105563

Merged
merged 1 commit into from
Oct 14, 2021
Merged

[go1.17] Update to go1.17.2 #105563

merged 1 commit into from
Oct 14, 2021

Conversation

mengjiao-liu
Copy link
Member

@mengjiao-liu mengjiao-liu commented Oct 8, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency release-eng security

What this PR does / why we need it:

Which issue(s) this PR fixes:

Ref kubernetes/release#2254

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.17.2

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider labels Oct 8, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 8, 2021
@24sama 24sama mentioned this pull request Oct 8, 2021
Closed
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 12, 2021
@mengjiao-liu
Copy link
Member Author

mengjiao-liu commented Oct 13, 2021 •
edited
Loading

PR kubernetes/release#2285 is merged.
Wait until images is successfully built and image promotion:（releng: Promote go1.17.2 / go1.16.9 images in kubernetes/k8s.io repo).

@mengjiao-liu mengjiao-liu changed the title [WIP][go1.17] Update to go1.17.2 [go1.17] Update to go1.17.2 Oct 13, 2021
@mengjiao-liu mengjiao-liu marked this pull request as ready for review October 13, 2021 15:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2021
@mengjiao-liu
Copy link
Member Author

watch release images https://prow.k8s.io/?type=postsubmit
/hold

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 14, 2021
@cpanato
Copy link
Member

cpanato commented Oct 14, 2021

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

cpanato
cpanato approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@dims
Copy link
Member

dims commented Oct 14, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, mengjiao-liu, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@mengjiao-liu
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit d09ce7b into kubernetes:master Oct 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 14, 2021
@cpanato cpanato mentioned this pull request Oct 14, 2021
Merged
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 14, 2021
@MaciekPytel
Copy link
Contributor

Shouldn't this change be reflected in go.mod file (which still lists go1.16)?

@liggitt
Copy link
Member

liggitt commented Nov 4, 2021

Shouldn't this change be reflected in go.mod file (which still lists go1.16)?

no. switching the go.mod file to go1.17 has other implications we don't want (it denormalizes all transitive dependencies into the root go.mod file in ways that disrupt our dependency checking tools)

MaciekPytel added a commit to MaciekPytel/autoscaler that referenced this pull request Dec 28, 2021
@MaciekPytel
Update golang to 1.17.5
d56624c 
Kubernetes 1.23 uses that version and the vendored code no
longer compiles using go1.16 (which we used previously).
Following the upstream Kubernetes I'm leaving the go version
in go.mod file at 1.16, as bumping it to 1.17 changes go mod
behavior in a way that breaks some kubernetes tooling
(kubernetes/kubernetes#105563 (comment)
for context).
@MaciekPytel MaciekPytel mentioned this pull request Dec 28, 2021
Merged
marwanad pushed a commit to marwanad/autoscaler that referenced this pull request Jan 3, 2022
@MaciekPytel @marwanad
Update golang to 1.17.5
0bd575c 
Kubernetes 1.23 uses that version and the vendored code no
longer compiles using go1.16 (which we used previously).
Following the upstream Kubernetes I'm leaving the go version
in go.mod file at 1.16, as bumping it to 1.17 changes go mod
behavior in a way that breaks some kubernetes tooling
(kubernetes/kubernetes#105563 (comment)
for context).
MaciekPytel added a commit to MaciekPytel/autoscaler that referenced this pull request Jan 10, 2022
@MaciekPytel
Update golang to 1.17.5
d0e6089 
Kubernetes 1.23 uses that version and the vendored code no
longer compiles using go1.16 (which we used previously).
Following the upstream Kubernetes I'm leaving the go version
in go.mod file at 1.16, as bumping it to 1.17 changes go mod
behavior in a way that breaks some kubernetes tooling
(kubernetes/kubernetes#105563 (comment)
for context).
@MaciekPytel MaciekPytel mentioned this pull request Jan 10, 2022
Merged
MaciekPytel added a commit to MaciekPytel/autoscaler that referenced this pull request Jan 12, 2022
@MaciekPytel
Update golang to 1.17.5
1b4992e 
Kubernetes 1.23 uses that version and the vendored code no
longer compiles using go1.16 (which we used previously).
Following the upstream Kubernetes I'm leaving the go version
in go.mod file at 1.16, as bumping it to 1.17 changes go mod
behavior in a way that breaks some kubernetes tooling
(kubernetes/kubernetes#105563 (comment)
for context).
MaciekPytel added a commit to MaciekPytel/autoscaler that referenced this pull request Jan 17, 2022
@MaciekPytel
Update golang to 1.17.5
3eb9ed5 
Kubernetes 1.23 uses that version and the vendored code no
longer compiles using go1.16 (which we used previously).
Following the upstream Kubernetes I'm leaving the go version
in go.mod file at 1.16, as bumping it to 1.17 changes go mod
behavior in a way that breaks some kubernetes tooling
(kubernetes/kubernetes#105563 (comment)
for context).
MaciekPytel added a commit to MaciekPytel/autoscaler that referenced this pull request Jan 18, 2022
@MaciekPytel
Update golang to 1.17.5
bdac8c2 
Kubernetes 1.23 uses that version and the vendored code no
longer compiles using go1.16 (which we used previously).
Following the upstream Kubernetes I'm leaving the go version
in go.mod file at 1.16, as bumping it to 1.17 changes go mod
behavior in a way that breaks some kubernetes tooling
(kubernetes/kubernetes#105563 (comment)
for context).
MaxRink pushed a commit to MaxRink/autoscaler that referenced this pull request Feb 14, 2022
@MaciekPytel @MaxRink
Update golang to 1.17.5
a865c8c 
Kubernetes 1.23 uses that version and the vendored code no
longer compiles using go1.16 (which we used previously).
Following the upstream Kubernetes I'm leaving the go version
in go.mod file at 1.16, as bumping it to 1.17 changes go mod
behavior in a way that breaks some kubernetes tooling
(kubernetes/kubernetes#105563 (comment)
for context).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@brancz brancz Awaiting requested review from brancz

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@dims dims

@justaugustus justaugustus

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
9 participants
@mengjiao-liu @k8s-ci-robot @fedebongio @cpanato @dims @MaciekPytel @liggitt @saschagrunert @justaugustus