Fix leaking process in hostport proxy #10498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit 790bdefc4f40cda307171e52754f51a339f96ce3. |
thockin
force-pushed
the
hostport-to-service
branch
from
790bdef to
ed48de6
Compare
|
GCE e2e build/test failed for commit ed48de67c4f0337046627d7541304e562d985811. |
thockin
force-pushed
the
hostport-to-service
branch
from
ed48de6 to
e54c38d
Compare
|
GCE e2e build/test passed for commit e54c38d. |
|
Can I get a review on this? |
|
@ArtfulCoder for review |
|
ping @ArtfulCoder |
|
I somehow missed this. reviewing now. sorry for the delay. |
ArtfulCoder
added
the
lgtm
dchen1107
added a commit
that referenced
this pull request
Aug 6, 2015
Fix leaking process in hostport proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...also allow non-bash shell scripts.
Fixes #10494 and #10496
I verified the boilerplate against invalid files and it still flags them but now allows #!/bin/sh to pass.
low risk.