Fix Vagrant kube-up - missed file watch on systemd stops kubelet starting on initial kube-up #10492
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekwaynecarr
changed the title
|
GCE e2e build/test failed for commit 5122ea42f45e04d1e0573f8fc3fcd8f3d6230de4. |
|
LGTM; I'll have a merge conflict but no big deal. As I commented on #10488, I worry that we have deeper issues with Salt & systemd (saltstack/salt#16778), but we should express our dependencies (as in this PR) even if Salt isn't doing the right thing. |
derekwaynecarr
force-pushed
the
add_watch_service_file
branch
from
5122ea4 to
de78898
Compare
|
@zmerlynn - can you look at this today? it is blocking basic creation of kube cluster. |
|
@derekwaynecarr: Absolutely, when I saw that I screwed up it not making 0.20.2, I hung my head in shame. But we may actually have a 0.20.3. |
|
LGTM |
zmerlynn
added
the
lgtm
|
@dchen1107 for rubber stamp |
|
GCE e2e build/test passed for commit de78898. |
|
Cherrypick for 0.20. #10409 |
|
LGTM. Thanks for fixing it. |
|
@thockin second TL approval, please? |
|
LGTM |
zmerlynn
added a commit
that referenced
this pull request
Jul 1, 2015
Fix Vagrant kube-up - missed file watch on systemd stops kubelet starting on initial kube-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubelet was not starting because service.running phase of Kubelet was executing before the service file was authored to disk when on systemd environment.
Fixes #10522