Explain the reason why metaclient special processing metav1.DeleteOptions encoding #104573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
sig/api-machinery
sxllwx
force-pushed
the
refine/clear-comments-for-metaclient
branch
from
a56c9ce to
31be540
Compare
|
/ping @caesarxuchao |
|
/assign @caesarxuchao @lavalamp would you mind taking a look to this clarification? |
k8s-ci-robot
added
triage/accepted
lavalamp
reviewed
Aug 27, 2021
| @@ -124,6 +124,12 @@ func (c *client) Delete(ctx context.Context, name string, opts metav1.DeleteOpti | |||
| if len(name) == 0 { | |||
| return fmt.Errorf("name is required") | |||
| } | |||
| // if DeleteOptions are delivered to Negotiator for serialization, | |||
| // HTTP-Request header will bring "Content-Type: application/vnd.kubernetes.protobuf" | |||
| // apiextensions-apiserver uses unstructuredNegotiatedSerializer to decode the input, | |||
There was a problem hiding this comment.
@deads2k do you expect this?
Either way we need a test case.
…ions encoding metaclient explicitly specifies the Content-Type when executing Delete and DeleteCollection, and add test for that
sxllwx
force-pushed
the
refine/clear-comments-for-metaclient
branch
from
31be540 to
8976f6f
Compare
k8s-ci-robot
added
size/M
|
/approve Thanks for the bug fix! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, sxllwx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/release-note-none |
k8s-ci-robot
added
release-note-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When I read metadataclient, I found that its code structure is slightly different from the typed code structure. Because of the lack of comments, it is impossible to quickly understand why the Delete and DeleteCollection methods perform JSON serialization of metav1.DeleteOptions. I tried to modify it and conduct an integration test, only to find the reason for the special treatment. I think we should add a comment here to help other developers understand the reason for the special treatment here.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
#102685 (comment)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: