Update Web UI Bar Gauge Graphs #10422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bcbroussard
commented
Jun 26, 2015
bcbroussard
commented
- Changed file system abbreviation from 'FS' to Filesystem (UI is not as self-explanatory as it could be #9350)
- Made chart height dynamic and incorporated legend height change into the master code/datafile.go binary (kubernetes-ui Node Graph Legend is Cut Off #8726, Fixing Kubernetes UI Graph Component's Legend Height Issue #10165, UI has partially cut off view #9347)
- Updated the max colors for the graph, eliminating the black background (UI is not as self-explanatory as it could be #9350)
- Realigned the graph numbers
|
Admins, this is a low risk change, ok for v1 |
- Changed file system abbreviation from 'FS' to Filesystem - Made chart height dynamic and incorporated legend height change into the master code/datafile.go binary - Updated the max colors for the graph - Realigned graph numbers
bcbroussard
force-pushed
the
gauge-colors
branch
from
7e05756 to
2f43fc7
Compare
|
@lavalamp can you take a look at this? |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
@k8s-bot ok to test |
|
GCE e2e build/test passed for commit 2f43fc7. |
|
LGTM @davidopp for second LGTM |
|
LGTM |
davidopp
added
lgtm
a-robinson
added a commit
that referenced
this pull request
Jun 29, 2015
Update Web UI Bar Gauge Graphs
This was referenced Jul 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.