Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.22][go1.16] Update to go1.16.7 #104200

Merged
merged 1 commit into from
Aug 7, 2021
Merged

[1.22][go1.16] Update to go1.16.7 #104200

merged 1 commit into from
Aug 7, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 6, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

Update Kubernetes to go1.16.7

Tracking issue: kubernetes/release#2196

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.16.7

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@cpanato
Update to go1.16.7
53fb477 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 6, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2021
@cpanato cpanato changed the title Automated cherry pick of #104199: Update to go1.16.7 [1.22][go1.16] Update to go1.16.7 Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 6, 2021
@cpanato
Copy link
Member Author

cpanato commented Aug 6, 2021

/assign @dims @liggitt @justaugustus
cc: @kubernetes/release-engineering

dims
dims reviewed Aug 6, 2021
View reviewed changes
build/dependencies.yaml
@@ -124,7 +124,7 @@ dependencies:
match: minimum_go_version=go([0-9]+\.[0-9]+)

- name: "k8s.gcr.io/kube-cross: dependents"
version: v1.16.6-1
version: v1.16.7-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.16.7-0 or v1.16.7-1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we built v1.16.7-1 following the other, but I agree that should be -0
:/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/release/pull/2197/files#diff-9d27d65f78671b29185b413d109ff0a70ddc2a5f7e5ca474ce6674224bff1ca1R19

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.16.7-0 or v1.16.7-1?

v1.16.7-1 is correct. The -1 is considered to be a "revision" number, similar to Debian revisions, starting at 1.

@dims
Copy link
Member

dims commented Aug 6, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 6, 2021
@cpanato cpanato mentioned this pull request Aug 6, 2021
Closed
29 tasks
@liggitt
Copy link
Member

liggitt commented Aug 6, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Aug 6, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 6, 2021
@cpanato
Copy link
Member Author

cpanato commented Aug 6, 2021

/test pull-kubernetes-integration

@justaugustus
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 7, 2021
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3ff0102 into kubernetes:release-1.22 Aug 7, 2021
@cpanato cpanato deleted the automated-cherry-pick-of-#104199-upstream-release-1.22 branch August 7, 2021 11:14
@cpanato cpanato mentioned this pull request Aug 7, 2021
Merged
@rifelpet rifelpet mentioned this pull request Aug 17, 2021
Merged
seanmalloy added a commit to KohlsTechnology/descheduler that referenced this pull request Aug 18, 2021
@seanmalloy
Bump To Go 1.16.7
b56a1ab 
The main k/k repo was updated to Go 1.16.7 for k8s
v1.22.0 release. See below PR for reference.

kubernetes/kubernetes#104200
@seanmalloy seanmalloy mentioned this pull request Aug 18, 2021
Merged
briend pushed a commit to briend/descheduler that referenced this pull request Feb 11, 2022
Bump To Go 1.16.7
c56a579 
The main k/k repo was updated to Go 1.16.7 for k8s
v1.22.0 release. See below PR for reference.

kubernetes/kubernetes#104200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus left review comments

@dims dims dims left review comments

@andyxning andyxning Awaiting requested review from andyxning

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@dims dims

@justaugustus justaugustus

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@cpanato @k8s-ci-robot @dims @liggitt @justaugustus