Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Provide IPv6 support for internal load balancer #103794

Merged
merged 1 commit into from
Jul 29, 2021
Merged

fix: Provide IPv6 support for internal load balancer #103794

merged 1 commit into from
Jul 29, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented Jul 20, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Cherry pick from kubernetes-sigs/cloud-provider-azure#703: feat: Provide IPv6 support for internal load balancer.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: Provide IPv6 support for internal load balancer

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/triage accepted
/sig cloud-provider
/area provider/azure
/priority critical-urgent
cc @feiskyer

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/azure Issues or PRs related to azure provider priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jul 20, 2021
@nilo19
Copy link
Member Author

nilo19 commented Jul 20, 2021

/retest

@aojea
Copy link
Member

aojea commented Jul 20, 2021

/assign @khenidak @aramase

aramase
aramase reviewed Jul 20, 2021
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2021
@aramase
Copy link
Member

aramase commented Jul 20, 2021 •
edited
Loading

/hold

for review from @feiskyer

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
feiskyer
feiskyer approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2021
@khenidak
Copy link
Contributor

/lgtm

@khenidak
Copy link
Contributor

/approve

@nilo19
Copy link
Member Author

nilo19 commented Jul 29, 2021

/milestone v1.22

@k8s-ci-robot
Copy link
Contributor

@nilo19: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nilo19
Copy link
Member Author

nilo19 commented Jul 29, 2021

@feiskyer need milestone to merge

@feiskyer
Copy link
Member

@cheftako @dims could you help to approve this bug fix?

@feiskyer
Copy link
Member

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 29, 2021
@cheftako
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, feiskyer, khenidak, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit b302770 into kubernetes:master Jul 29, 2021
@nilo19 nilo19 deleted the bug/cherry-pick-703 branch July 30, 2021 07:54
This was referenced Jul 30, 2021
Merged
Merged
@ialidzhikov
Copy link
Contributor

Same as #103997 (comment). Can you create a cherry-pick for release-1.22 branch?

@cheftako
Copy link
Member

cheftako commented Jul 30, 2021 •
edited
Loading

@feiskyer or @nilo19 Can you generate the v1.22 cherry-pick?

@ialidzhikov ialidzhikov mentioned this pull request Jul 31, 2021
Merged
@ialidzhikov
Copy link
Contributor

@feiskyer or @nilo19 Can you generate the v1.22 cherry-pick?

#104051

k8s-ci-robot added a commit that referenced this pull request Aug 2, 2021
@k8s-ci-robot
Merge pull request #104051 from ialidzhikov/automated-cherry-pick-of-…
102023a 
…#103794-upstream-release-1.22

Automated cherry pick of #103794: feat: Provide IPv6 support for internal load balancer
k8s-ci-robot added a commit that referenced this pull request Aug 6, 2021
@k8s-ci-robot
Merge pull request #104027 from nilo19/automated-cherry-pick-of-#1037…
b993029 
…94-upstream-release-1.20

Automated cherry pick of #103794: feat: Provide IPv6 support for internal load balancer
k8s-ci-robot added a commit that referenced this pull request Aug 6, 2021
@k8s-ci-robot
Merge pull request #104028 from nilo19/automated-cherry-pick-of-#1037…
5d0a74b 
…94-upstream-release-1.21

Automated cherry pick of #103794: feat: Provide IPv6 support for internal load balancer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@khenidak khenidak khenidak approved these changes

@feiskyer feiskyer feiskyer approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@feiskyer feiskyer

@cheftako cheftako

@aramase aramase

@khenidak khenidak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
8 participants
@nilo19 @aojea @aramase @khenidak @k8s-ci-robot @feiskyer @cheftako @ialidzhikov