Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate endpoints over a 1000 addresses #103520

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Truncate endpoints over a 1000 addresses #103520

merged 1 commit into from
Jul 8, 2021

Conversation

swetharepakula
Copy link
Member

  • set endpoints.kubernetes.io/over-capacity to "truncated" when
    number of addresses has been truncated to a 1000

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR will enforce the recommended 1000 endpoint maxCapacity limit on Endpoints resources. If the number of endpoints exceeds 1000, they will be truncated now.

Special notes for your reviewer:

This is the final PR needed to close out KEP: EndpointSlice KEP.

Does this PR introduce a user-facing change?

Endpoints that have more than 1000 endpoints will be truncated and the `endpoints.kubernetes.io/over-capacity` annotation on the Endpoints resource will be set to `truncated`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: EndpointSlice KEP
Enhancement Issue: kubernetes/enhancements#752

/cc @aojea @andrewsykim @liggitt @robscott @wojtek-t
/assign @thockin
/sig network
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 6, 2021
@k8s-ci-robot k8s-ci-robot requested a review from andrewsykim July 6, 2021 18:33
@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jul 6, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jul 6, 2021
@swetharepakula
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 6, 2021
@swetharepakula swetharepakula mentioned this pull request Jul 6, 2021
Closed
thockin
thockin reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swetharepakula, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2021
@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2021
robscott
robscott reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this! Mostly LGTM.

pkg/controller/endpoint/endpoints_controller.go Show resolved Hide resolved
pkg/controller/endpoint/endpoints_controller.go Outdated Show resolved Hide resolved
pkg/controller/endpoint/endpoints_controller.go Outdated Show resolved Hide resolved
pkg/controller/endpoint/endpoints_controller.go Outdated Show resolved Hide resolved
@swetharepakula
Copy link
Member Author

/hold
Working on an update based on @robscott's suggestion about distributing endpoints over subsets.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2021
@swetharepakula
Copy link
Member Author

/hold cancel

Updated the approach to truncate proportionally across the subsets

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@dims
Copy link
Member

dims commented Jul 7, 2021

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 7, 2021
@swetharepakula
Copy link
Member Author

/retest

@robscott
Copy link
Member

robscott commented Jul 7, 2021

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@swetharepakula
Truncate endpoints over a 1000 addresses
9bd857c 
 * set `endpoints.kubernetes.io/over-capacity` to "truncated" when
 number of addresses has been truncated to a 1000
 * ready addresses are prioritized over non-ready addresses
 * addresses are proportionally truncated across subsets
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@robscott
Copy link
Member

robscott commented Jul 7, 2021

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2021
@swetharepakula
Copy link
Member Author

/retest
Integration timeout flakes: #103512

@swetharepakula
Copy link
Member Author

swetharepakula commented Jul 7, 2021 •
edited
Loading

/retest
Same integration timeout flakes

@k8s-ci-robot k8s-ci-robot merged commit 16af282 into kubernetes:master Jul 8, 2021
@swetharepakula swetharepakula mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@robscott robscott robscott left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@aojea aojea Awaiting requested review from aojea

@liggitt liggitt Awaiting requested review from liggitt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@robscott robscott

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@swetharepakula @k8s-ci-robot @dims @robscott @thockin