Add distributed tracing to the etcd client #103216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
area/apiserver
sig/api-machinery
|
/sig instrumentation |
k8s-ci-robot
added
the
sig/instrumentation
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/test all |
dashpole
force-pushed
the
etcd_client_tracing
branch
from
f0da0b3 to
04fabac
Compare
k8s-ci-robot
added
area/cloudprovider
area/dependency
|
/test all |
dashpole
force-pushed
the
etcd_client_tracing
branch
from
04fabac to
71f810b
Compare
|
/test all |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @kubernetes/sig-instrumentation-leads @lilic |
3 tasks
|
/assign @lilic @logicalhan |
k8s-ci-robot
added
the
lgtm
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/assign @liggitt |
liggitt
reviewed
Jul 8, 2021
Comment on lines
+152
to
+154
| dialOptions = append(dialOptions, | ||
| grpc.WithUnaryInterceptor(otelgrpc.UnaryClientInterceptor(tracingOpts...)), | ||
| grpc.WithStreamInterceptor(otelgrpc.StreamClientInterceptor(tracingOpts...))) |
There was a problem hiding this comment.
I don't know enough about the grpc wiring to know the implications of this bit... would like an ack from an etcd reviewer
There was a problem hiding this comment.
This part looks good to me.
|
/assign @wenjiaswe @jingyih |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dashpole, liggitt, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds tracing for etcd client requests, and propagates context to etcd to connect apiserver spans with spans from etcd-io/etcd#12919.
Part of enhancement: kubernetes/enhancements#647
Special notes for your reviewer:
I followed the pattern used by the EgressLookup config to plumb it through to the etcd client. In order to avoid globals (as requested in the initial tracing review), we pass the TracerProvider via config instead of using the global one. Rather than add etcd options for tracing separately, we copy the tracing-related options into the etcd config after the TracerProvider is initialized.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
For illustration, see the example below:
The top span is the span added in #94942. The bottom span comes from ETCD, and was added in etcd-io/etcd#12919. The middle span is from this PR, and links the top and bottom spans!