Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endpointslicemirroring controller mirror address status #102683

Merged
merged 1 commit into from
Jun 8, 2021
Merged

endpointslicemirroring controller mirror address status #102683

merged 1 commit into from
Jun 8, 2021

Conversation

aojea
Copy link
Member

@aojea aojea commented Jun 8, 2021 •
edited by liggitt
Loading

Fix a bug on the endpoint slice mirroring controller where the
endpoints not ready addresses were mirrored as ready.

Initially reported in slack https://kubernetes.slack.com/archives/C09QYUH5W/p1623045110181900 by @weirdmachine

/kind bug

Fix a regression in 1.19+ where the endpoint slices mirroring controller where endpoint NotReadyAddresses were mirrored as Ready to the corresponding EndpointSlice

@aojea
endpointslicemirroring controller mirror address status
3ac8d8c 
Fix a bug on the endpoint slice mirroring controller where the
endpoints not ready addresses were mirrored as ready.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

@aojea: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 8, 2021
@aojea
Copy link
Member Author

aojea commented Jun 8, 2021

/assign @freehan @robscott
/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from danwinship and MrHohn June 8, 2021 07:55
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jun 8, 2021
@aojea
Copy link
Member Author

aojea commented Jun 8, 2021

/assign @freehan @robscott

@robscott
Copy link
Member

robscott commented Jun 8, 2021

Thanks for catching and fixing this! Seems like we should also cherry pick this back as far as possible.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5a21b97 into kubernetes:master Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 8, 2021
This was referenced Jun 8, 2021
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 9, 2021
@k8s-ci-robot
Merge pull request #102702 from aojea/automated-cherry-pick-of-#10268…
dab8df8 
…3-upstream-release-1.21

Automated cherry pick of #102683: endpointslicemirroring controller mirror address status
k8s-ci-robot added a commit that referenced this pull request Jun 9, 2021
@k8s-ci-robot
Merge pull request #102703 from aojea/automated-cherry-pick-of-#10268…
88ad9ae 
…3-upstream-release-1.20

Automated cherry pick of #102683: endpointslicemirroring controller mirror address status
@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@robscott robscott

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@aojea @k8s-ci-robot @robscott @liggitt @freehan