Deprecated message for ignore-errors flag #102677
Conversation
k8s-ci-robot
added
release-note
|
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
|
/assign @apelisse |
|
/assign @eddiezane |
| @@ -310,6 +310,9 @@ func (o *DrainCmdOptions) RunDrain() error { | |||
| fmt.Fprintf(o.ErrOut, "error: unable to drain node %q due to error:%s, continuing command...\n", info.Name, err) | |||
| continue | |||
| } | |||
| fmt.Fprintf(o.ErrOut, "DEPRECATED WARNING: Aborting the drain command in a list of nodes will be deprecated.\n"+ | |||
There was a problem hiding this comment.
Do we know what version?
?
There was a problem hiding this comment.
Sorry should have been more clear.
Is there a targeted Kubernetes version for this change that we can include in the deprecation warning?
There was a problem hiding this comment.
Sorry should have been more clear.
Is there a targeted Kubernetes version for this change that we can include in the deprecation warning?
Add deprecated message in v1.22
Set ignore errors default to true, and remove --ignore-errors flag in v1.23
Add version plan in message?
There was a problem hiding this comment.
Yes please. If we know the plan it's a good way to communicate that to users.
There was a problem hiding this comment.
DEPRECATED WARNING: Aborting the drain command in a list of nodes is deprecated in v1.22 and will be removed in v1.23
There was a problem hiding this comment.
In v1.22 just add an DEPRECATED WARNING message, it will be deprecated and removed in v1.23, so may be just
DEPRECATED WARNING: Aborting the drain command in a list of nodes will be deprecated in v1.23.
|
/retitle Deprecated message for ignore-errors flag |
k8s-ci-robot
changed the title
|
In general the patch LGTM. I hope we have time to add it to v1.22 after adding the changes eddie asked. |
yuzhiquan
force-pushed
the
deprecated-warning-for-drain
branch
from
e84232e to
0a38b28
Compare
|
Ty /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cndoit18, eddiezane, yuzhiquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Thanks, and a lgtm is required @dougsland @eddiezane |
|
Ping @dougsland @eddiezane for lgtm label. |
k8s-ci-robot
added
the
lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Refs #100052
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @dougsland @coderanger @eddiezane
/priority backlog
/triage accepted
/sig cli