-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update top level logging documentation #10258
Conversation
656b72d
to
3f3036c
Compare
GCE e2e build/test passed for commit 656b72daf1cc628c7153ff091b828284b35df495. |
GCE e2e build/test passed for commit 3f3036cd4cc0492d82659b7c93c8a144bd07573f. |
(Pressed for time—@satnam6502 assigning to you to find a reviewer. Someone should take a one-over, at least. My one questions is why we're removing all mentions of elasticsearch [perhaps it's all on subpages now?]) |
A different page has been added for Elasticsearch + Kibana and I will link to that in a subsequent PR. |
3f3036c
to
da39e53
Compare
Added a section about Elasticsearch and Kibana. |
Removed absolute paths at the request of @RichieEscarez |
Looks great, sorry if I gave you outdated advice about using absolute rather than relative paths. |
GCE e2e build/test passed for commit da39e53. |
``` | ||
$ curl -k -u admin:Drt3KdRGnoQL6TQM https://130.211.152.93/api/v1/proxy/namespaces/default/services/elasticsearch-logging/_search?size=10 | ||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not worth doing a re-push for this, but I (personally) like having syntax highlighting for supported languages in documentation, so in the future could you toss a <lang> at the top (in this case
yaml)?
Update top level logging documentation
No description provided.