Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update top level logging documentation #10258

Merged
merged 1 commit into from
Jun 25, 2015

Conversation

satnam6502
Copy link
Contributor

No description provided.

@k8s-bot
Copy link

k8s-bot commented Jun 23, 2015

GCE e2e build/test passed for commit 656b72daf1cc628c7153ff091b828284b35df495.

@k8s-bot
Copy link

k8s-bot commented Jun 23, 2015

GCE e2e build/test passed for commit 3f3036cd4cc0492d82659b7c93c8a144bd07573f.

@mbforbes
Copy link
Contributor

(Pressed for time—@satnam6502 assigning to you to find a reviewer. Someone should take a one-over, at least. My one questions is why we're removing all mentions of elasticsearch [perhaps it's all on subpages now?])

@satnam6502
Copy link
Contributor Author

A different page has been added for Elasticsearch + Kibana and I will link to that in a subsequent PR.

@satnam6502 satnam6502 assigned a-robinson and unassigned satnam6502 Jun 24, 2015
@satnam6502
Copy link
Contributor Author

Added a section about Elasticsearch and Kibana.

@satnam6502
Copy link
Contributor Author

Removed absolute paths at the request of @RichieEscarez

@a-robinson
Copy link
Contributor

Looks great, sorry if I gave you outdated advice about using absolute rather than relative paths.

@a-robinson a-robinson added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2015
@k8s-bot
Copy link

k8s-bot commented Jun 24, 2015

GCE e2e build/test passed for commit da39e53.

```
$ curl -k -u admin:Drt3KdRGnoQL6TQM https://130.211.152.93/api/v1/proxy/namespaces/default/services/elasticsearch-logging/_search?size=10
apiVersion: v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not worth doing a re-push for this, but I (personally) like having syntax highlighting for supported languages in documentation, so in the future could you toss a <lang> at the top (in this case yaml)?

mbforbes added a commit that referenced this pull request Jun 25, 2015
Update top level logging documentation
@mbforbes mbforbes merged commit 4237fb2 into kubernetes:master Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants