Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: remove --insecure-port flag from the kube-apiserver manifest #102121

Merged
merged 1 commit into from
May 20, 2021
Merged

kubeadm: remove --insecure-port flag from the kube-apiserver manifest #102121

merged 1 commit into from
May 20, 2021

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented May 19, 2021 •
edited
Loading

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

Flag --insecure-port has been deprecated, **This flag has no effect now and will be removed in v1.24.**
Error: invalid port value 28080: only zero is allowed

As this flag has no effect, we can just remove it in kubeadm side in 1.22 now.

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#2156

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: remove the deprecated flag --insecure-port from the kube-apiserver manifest that kubeadm manages. The flag had no effect since 1.20, since the insecure serving of the component was disabled in the same version.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 19, 2021
@pacoxu
Copy link
Member Author

pacoxu commented May 19, 2021

/kind cleanup
/priority important-soon
/milestone v1.22
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 19, 2021
@k8s-ci-robot
Copy link
Contributor

@pacoxu: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/kind cleanup
/priority important-soon
/milestone v1.22
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 19, 2021
@pacoxu
Copy link
Member Author

pacoxu commented May 19, 2021

/retest

@neolit123
Copy link
Member

/retitle kubeadm: remove --insecure-port flag from the kube-apiserver manifest

@k8s-ci-robot k8s-ci-robot changed the title kubeadm: remove deprecated --insecure-port as this flag has no effect kubeadm: remove --insecure-port flag from the kube-apiserver manifest May 19, 2021
@neolit123
Copy link
Member

suggesting release note change:

kubeadm: remove the deprecated flag --insecure-port from the kube-apiserver manifest that kubeadm manages. The flag had no effect since 1.20, since insecure serving of the component was disabled in the same version.

@neolit123
Copy link
Member

thanks @pacoxu
we can merge this change after you update the release note.

/milestone v1.12
/approve
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021
@k8s-ci-robot
Copy link
Contributor

@neolit123: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22]

Use /milestone clear to clear the milestone.

In response to this:

thanks @pacoxu
we can merge this change after you update the release note.

/milestone v1.12
/approve
/lgtm
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 19, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021
@pacoxu
Copy link
Member Author

pacoxu commented May 20, 2021

The release note is updated.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3cd555e into kubernetes:master May 20, 2021
@github-actions github-actions bot mentioned this pull request May 26, 2021
Open
@pacoxu pacoxu deleted the remove-insecure-ports branch June 23, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@RA489 RA489 Awaiting requested review from RA489

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

remove kube-apiserver --insecure-port usage
3 participants
@pacoxu @k8s-ci-robot @neolit123