Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: remove the deprecated flag '--image-pull-timeout' for 'kubeadm upgrade apply' command #102093

Merged
merged 1 commit into from
May 18, 2021
Merged

kubeadm: remove the deprecated flag '--image-pull-timeout' for 'kubeadm upgrade apply' command #102093

merged 1 commit into from
May 18, 2021

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented May 18, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

kubeadm: remove the deprecated flag '--image-pull-timeout' for 'kubeadm upgrade apply' command.
This flag was deprecated in 1.19.
Remove it as scheduled in 1.22.

Which issue(s) this PR fixes:

Ref #90788

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: remove the deprecated flag '--image-pull-timeout' for 'kubeadm upgrade apply' command

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 18, 2021
@k8s-ci-robot k8s-ci-robot requested review from pacoxu and RA489 May 18, 2021 12:39
@SataQiu
Copy link
Member Author

SataQiu commented May 18, 2021

/priority important-soon
/milestone v1.22
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 18, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 18, 2021
@k8s-ci-robot k8s-ci-robot removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 18, 2021
@SataQiu
Copy link
Member Author

SataQiu commented May 18, 2021

/cc @neolit123

@k8s-ci-robot k8s-ci-robot requested a review from neolit123 May 18, 2021 12:41
@neolit123
Copy link
Member

thanks @SataQiu
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit c24f2f8 into kubernetes:master May 18, 2021
@github-actions github-actions bot mentioned this pull request May 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu Awaiting requested review from pacoxu

@RA489 RA489 Awaiting requested review from RA489

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@SataQiu @k8s-ci-robot @neolit123