Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable protocol-buffers by default #102039

Merged
merged 1 commit into from
May 31, 2021
Merged

Enable protocol-buffers by default #102039

merged 1 commit into from
May 31, 2021

Conversation

serathius
Copy link
Contributor

@serathius serathius commented May 16, 2021 •
edited
Loading

/kind feature

[kubectl] Enable using protocol buffers to request Metrics API

Flag was added in 1.21 with agreement that it will be enabled by default in next release.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2021
@serathius
Copy link
Contributor Author

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2021
@k8s-ci-robot k8s-ci-robot requested review from dixudx and soltysh May 16, 2021 16:31
@serathius
Copy link
Contributor Author

/assign @soltysh

@serathius
Copy link
Contributor Author

/retest

1 similar comment
@serathius
Copy link
Contributor Author

/retest

soltysh
soltysh approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/priority backlog
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@serathius
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
pacoxu
pacoxu reviewed May 25, 2021
View reviewed changes
staging/src/k8s.io/kubectl/pkg/cmd/top/top_pod.go
@@ -87,6 +87,7 @@ func NewCmdTopPod(f cmdutil.Factory, o *TopPodOptions, streams genericclioptions
if o == nil {
o = &TopPodOptions{
IOStreams: streams,
UseProtocolBuffers: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need format code here.

@pacoxu
Copy link
Member

pacoxu commented May 25, 2021

/cc

@k8s-ci-robot k8s-ci-robot requested a review from pacoxu May 25, 2021 02:43
@pacoxu
Copy link
Member

pacoxu commented May 31, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit 14e4ed0 into kubernetes:master May 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 31, 2021
@github-actions github-actions bot mentioned this pull request Jun 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dixudx dixudx Awaiting requested review from dixudx

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@soltysh soltysh

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@serathius @k8s-ci-robot @pacoxu @soltysh