Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of #101739: fix: avoid nil-pointer panic when checking the frontend IP configuration #101886

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Cherry pick of #101739: fix: avoid nil-pointer panic when checking the frontend IP configuration #101886

merged 1 commit into from
Jun 9, 2021

Conversation

nilo19
Copy link
Member

@nilo19 nilo19 commented May 11, 2021 •
edited
Loading

Cherry pick of #101739 on release-1.20.

#101739: fix: avoid nil-pointer panic when checking the frontend IP configuration

For details on the cherry pick process, see the cherry pick requests page.

/triage accepted
/priority critical-urgent
/sig cloud-provider
/area provider/azure
/kind bug

cc @feiskyer

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone May 11, 2021
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/azure Issues or PRs related to azure provider kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2021
@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and ritazh May 11, 2021 01:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/cloudprovider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2021
@nilo19
Copy link
Member Author

nilo19 commented May 11, 2021

/retest

1 similar comment
@nilo19
Copy link
Member Author

nilo19 commented May 11, 2021

/retest

feiskyer
feiskyer reviewed May 17, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
@nilo19
Copy link
Member Author

nilo19 commented May 17, 2021

/retest

2 similar comments
@chewong
Copy link
Member

chewong commented May 18, 2021

/retest

@chewong
Copy link
Member

chewong commented May 18, 2021

/retest

@feiskyer
Copy link
Member

thanks @chewong fixed the e2e test failures

@jackfrancis
Copy link
Contributor

What's the status on this being merged?

cc @Michael-Sinz

@jackfrancis jackfrancis mentioned this pull request Jun 7, 2021
Merged
This was referenced Jun 8, 2021
Closed
Closed
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jun 8, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@jackfrancis
Copy link
Contributor

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@nilo19
Copy link
Member Author

nilo19 commented Jun 9, 2021

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d5eb450 into kubernetes:release-1.20 Jun 9, 2021
@nilo19 nilo19 deleted the automated-cherry-pick-of-#101739-upstream-release-1.20 branch June 10, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
6 participants
@nilo19 @k8s-ci-robot @chewong @feiskyer @jackfrancis @fejta-bot