Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ReallyCrashForTesting and cleaned up some references to Handle… #101719

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Remove ReallyCrashForTesting and cleaned up some references to Handle… #101719

merged 1 commit into from
Dec 8, 2021

Conversation

SergeyKanzhelev
Copy link
Member

What type of PR is this?

/kind bug
/kind cleanup

/sig node
/priority important-longterm

What this PR does / why we need it:

The flag --really-crash-for-testing was deprecated for over a year: #90499 And at that time it was already never set.

This error #101012 wasn't caught as the default for tests was not to panic.

Does this PR introduce a user-facing change?

The deprecated flag `--really-crash-for-testing` is removed.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 3, 2021
@SergeyKanzhelev
Copy link
Member Author

/cc @knabben

@k8s-ci-robot k8s-ci-robot requested a review from knabben May 3, 2021 22:36
@k8s-ci-robot k8s-ci-robot requested review from aojea and bowei May 3, 2021 22:38
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 3, 2021
@SergeyKanzhelev SergeyKanzhelev force-pushed the removeReallyCrashForTesting branch from 754bb7e to 92d73a7 Compare May 4, 2021 00:10
@knabben
Copy link
Member

knabben commented May 4, 2021

/lgtm

@knabben
Copy link
Member

knabben commented May 4, 2021

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2021
@SergeyKanzhelev
Copy link
Member Author

/triage accepted
/retest

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 4, 2021
@SergeyKanzhelev
Copy link
Member Author

/retest

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Nov 8, 2021
Merged
@SergeyKanzhelev
Copy link
Member Author

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Nov 15, 2021
@aojea
Copy link
Member

aojea commented Nov 16, 2021

/assign @liggitt
as he was approver for the deprecation

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2021
@liggitt
Copy link
Member

liggitt commented Nov 29, 2021

kubelet changes seem fine, though I don't see the need to rename the package var

@SergeyKanzhelev
Copy link
Member Author

kubelet changes seem fine, though I don't see the need to rename the package var

The intention was to highlight the fact that this is only for tests and not intended as a production behavior.

@liggitt
Copy link
Member

liggitt commented Nov 29, 2021

The intention was to highlight the fact that this is only for tests and not intended as a production behavior.

in the kubelet, it is... I don't know that that's true for all consumers of the apimachinery util package

@SergeyKanzhelev SergeyKanzhelev force-pushed the removeReallyCrashForTesting branch from ba8831f to 7d356d8 Compare November 29, 2021 19:55
@SergeyKanzhelev SergeyKanzhelev force-pushed the removeReallyCrashForTesting branch from 7d356d8 to a11453e Compare November 29, 2021 20:00
@SergeyKanzhelev
Copy link
Member Author

The intention was to highlight the fact that this is only for tests and not intended as a production behavior.

in the kubelet, it is... I don't know that that's true for all consumers of the apimachinery util package

Makes sense. Renamed back

@liggitt
Copy link
Member

liggitt commented Nov 29, 2021

/approve

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2021
endocrimes
endocrimes approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: endocrimes, liggitt, mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@pacoxu
Copy link
Member

pacoxu commented Dec 8, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit f356ae4 into kubernetes:master Dec 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 8, 2021
@SergeyKanzhelev SergeyKanzhelev deleted the removeReallyCrashForTesting branch December 8, 2021 07:49
@likakuli likakuli mentioned this pull request Dec 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@mrunalp mrunalp mrunalp approved these changes

@knabben knabben Awaiting requested review from knabben

@aojea aojea Awaiting requested review from aojea

@bowei bowei Awaiting requested review from bowei

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@knabben knabben

@endocrimes endocrimes

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
10 participants
@SergeyKanzhelev @knabben @k8s-ci-robot @liggitt @BenTheElder @aojea @pacoxu @mrunalp @endocrimes @smarterclayton