Deprecate removal of CSI nodepublish path by kubelet (#101332) #101441

dobsonj · 2021-04-23T23:19:36Z

What type of PR is this?

/kind bug
/kind deprecation

What this PR does / why we need it:

This deprecates removal of the CSI nodepublish path by kubelets. This must be handled by the CSI plugin.

Which issue(s) this PR fixes:

Fixes #101332

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Yes

Removal of the CSI nodepublish path by the kubelet is deprecated. This must be done by the CSI plugin according to the CSI spec.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [CSI spec]: https://github.com/container-storage-interface/spec/blob/da58351ba3d7baf850877be3425e76ff30645d33/spec.md#nodeunpublishvolume

k8s-ci-robot · 2021-04-23T23:19:39Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-04-23T23:19:44Z

Welcome @dobsonj!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-04-23T23:19:44Z

Hi @dobsonj. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dobsonj · 2021-04-26T17:14:33Z

retest CLA

gnufied · 2021-04-27T14:15:23Z

/ok-to-test

gnufied · 2021-04-27T14:16:14Z

/priority important-soon
/triage accepted

pkg/volume/csi/csi_mounter.go

dobsonj · 2021-04-27T19:28:12Z

/retest

dobsonj · 2021-04-27T19:33:50Z

flake: #100788 (pull-kubernetes-node-e2e)
flake: #101275 (pull-kubernetes-e2e-kind)

gnufied · 2021-04-27T23:26:11Z

pkg/volume/csi/csi_mounter.go

-	// clean mount point dir
+	// Deprecation: Removal of this mount directory MUST be done by
+	// the CSI plugin according to the spec. This will no longer be done
+	// directly as part of TearDown by the kubelet in the future.
 	if err := removeMountDir(c.plugin, dir); err != nil {


sorry about keep going back and forth on this but - we should be explicit in comment as well that we are only deprecating support for removing NodePublish target_path, removal of parent directories are still a responsibility of kubelet.

So something like:

Deprecation: Removal of target_path provided in NodePublish RPC call (in this case location dir)
MUST be done by the CSI plugin according to the spec.
This will no longer be done directly as part of TearDown by the kubelet in the future.Kubelet will only be
responsible for removal of json data files it creates and parent directories.

All good, thanks for the feedback 👍

gnufied · 2021-04-27T23:55:59Z

/lgtm

jsafrane · 2021-04-28T15:46:15Z

/approve

k8s-ci-robot · 2021-04-28T15:46:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/volume/csi/OWNERS~~ [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 23, 2021

k8s-ci-robot requested review from verult and xing-yang April 23, 2021 23:20

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 26, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2021

gnufied reviewed Apr 27, 2021

View reviewed changes

pkg/volume/csi/csi_mounter.go Outdated Show resolved Hide resolved

Deprecate removal of CSI nodepublish path by kubelet (kubernetes#101332)

e92dc8d

dobsonj force-pushed the 101332-deprecate-mount-path-removal branch from 0901028 to e92dc8d Compare April 27, 2021 14:42

dobsonj marked this pull request as ready for review April 27, 2021 14:46

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2021

move deprecation comment to TearDownAt function

75a7966

gnufied reviewed Apr 27, 2021

View reviewed changes

clarify deprecation comment

260426b

k8s-ci-robot assigned gnufied Apr 27, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021

dobsonj mentioned this pull request Apr 28, 2021

Extend NodeUnpublish test to verify cleanup of TargetPath (#336) kubernetes-csi/csi-test#338

Merged

k8s-ci-robot merged commit 7f8539f into kubernetes:master Apr 28, 2021

k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021

dobsonj deleted the 101332-deprecate-mount-path-removal branch April 28, 2021 18:39

dobsonj mentioned this pull request Jun 21, 2021

REQUEST: New membership for dobsonj kubernetes/org#2799

Closed

6 tasks

carlory mentioned this pull request Nov 21, 2023

Remove deprecated comment about cleanup the target_path of CSI volumes #121978

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate removal of CSI nodepublish path by kubelet (#101332) #101441

Deprecate removal of CSI nodepublish path by kubelet (#101332) #101441

dobsonj commented Apr 23, 2021

k8s-ci-robot commented Apr 23, 2021

k8s-ci-robot commented Apr 23, 2021

k8s-ci-robot commented Apr 23, 2021

dobsonj commented Apr 26, 2021

gnufied commented Apr 27, 2021

gnufied commented Apr 27, 2021

dobsonj commented Apr 27, 2021

dobsonj commented Apr 27, 2021 •

edited

Loading

gnufied Apr 27, 2021

dobsonj Apr 27, 2021

gnufied commented Apr 27, 2021

jsafrane commented Apr 28, 2021

k8s-ci-robot commented Apr 28, 2021

Deprecate removal of CSI nodepublish path by kubelet (#101332) #101441

Deprecate removal of CSI nodepublish path by kubelet (#101332) #101441

Conversation

dobsonj commented Apr 23, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Apr 23, 2021

k8s-ci-robot commented Apr 23, 2021

k8s-ci-robot commented Apr 23, 2021

dobsonj commented Apr 26, 2021

gnufied commented Apr 27, 2021

gnufied commented Apr 27, 2021

dobsonj commented Apr 27, 2021

dobsonj commented Apr 27, 2021 • edited Loading

gnufied Apr 27, 2021

Choose a reason for hiding this comment

dobsonj Apr 27, 2021

Choose a reason for hiding this comment

gnufied commented Apr 27, 2021

jsafrane commented Apr 28, 2021

k8s-ci-robot commented Apr 28, 2021

dobsonj commented Apr 27, 2021 •

edited

Loading